On 05/29/2011 07:41 PM, Jan Kiszka wrote:
> > void qemu_cpu_kick(void *_env) > { > CPUState *env = _env; > > qemu_cond_broadcast(env->halt_cond); > if (!env->thread_kicked) { > qemu_cpu_kick_thread(env); > env->thread_kicked = true; > } > } > > Seems to have redundancies - we're both signalling a condition variable > and sending a signal. >The target may block on the halt condition or run in guest mode. I don't think we can (and should) try to find out which wakeup call is sufficient.
What we could do is make both waiters wait for the same event. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
