On 02/27/2013 12:55 PM, Michael S. Tsirkin wrote:
Add documentation about using qemu-system for unit tests.
Add runner script to select the correct binary and flags.

Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
  README  | 10 +++++++++-
  x86-run | 27 +++++++++++++++++++++++++++
  2 files changed, 36 insertions(+), 1 deletion(-)
  create mode 100755 x86-run

diff --git a/README b/README
index 4ceb869..214397c 100644
--- a/README
+++ b/README
@@ -10,10 +10,18 @@ To create the tests' images just type 'make' in this 
directory.
  Tests' images created in ./<ARCH>/*.flat

  An example of a test invocation:
-qemu-system-x86_64 -device testdev,chardev=testlog -chardev 
file,id=testlog,path=msr.out -serial stdio -kernel ./x86/msr.flat
+Using qemu-kvm:
+
+qemu-kvm -device testdev,chardev=testlog -chardev file,id=testlog,path=msr.out 
-serial stdio -kernel ./x86/msr.flat
  This invocation runs the msr test case. The test outputs to stdio.

+Using qemu (supported since qemu 1.3):
+qemu-system-x86_64 -enable-kvm -device pc-testdev -serial stdio -device 
isa-debug-exit,iobase=0xf4,iosize=0x4 -kernel ./x86/msr.flat

I think it is worth here to point out that with new qemu, after the unittest is done, the exit status of qemu is 1, different from the 'old style', whose exit status in successful completion is 0.

+Or use a runner script to detect the correct invocation:
+./x86-run ./x86/msr.flat
+To select a specific qemu binary, specify the QEMU=<path> environment:
+QEMU=/tmp/qemu/x86_64-softmmu/qemu-system-x86_64 ./x86-run ./x86/msr.flat

  Directory structure:
  .:  Makefile and config files for the tests
diff --git a/x86-run b/x86-run
new file mode 100755
index 0000000..cf1d38a
--- /dev/null
+++ b/x86-run
@@ -0,0 +1,27 @@
+#!/usr/bin/bash
+
+qemukvm="${QEMU:-qemu-kvm}"
+qemusystem="${QEMU:-qemu-system-x86_64}"
+if
+       ${qemukvm} -device '?' 2>&1 | fgrep -e \"testdev\" -e \"pc-testdev\" > 
/dev/null;
+then
+       qemu="${qemukvm}"
+else
+       if
+               ${qemsystem} -device '?' 2>&1 | fgrep -e \"testdev\" -e 
\"pc-testdev\" > /dev/null;
+       then
+               qemu="${qemusystem}"
+       else
+               echo QEMU binary ${QEMU} has no support for test device. 
Exiting.
+               exit 1
+       fi
+fi
+
+if
+       ${qemu} -device '?' 2>&1 | fgrep "pc-testdev" > /dev/null;
+then
+       command="${qemu} -enable-kvm -device pc-testdev -serial stdio -device 
isa-debug-exit,iobase=0xf4,iosize=0x4 -kernel"
+else
+       command="${qemu} -device testdev,chardev=testlog -chardev 
file,id=testlog,path=msr.out -serial stdio -kernel ./x86/msr.flat"
+fi
+exec ${command} "$@"

^ What about checking the exit status of qemu here and print something like "test $@ PASS" or "test $@ FAIL"?

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to