Hi Paolo, > -----Original Message----- > From: Paolo Bonzini <[email protected]> > Sent: Wednesday, October 16, 2019 12:39 AM > To: Jianyong Wu (Arm Technology China) <[email protected]>; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Mark Rutland <[email protected]>; > [email protected]; Suzuki Poulose <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; Steve Capper > <[email protected]>; Kaly Xin (Arm Technology China) > <[email protected]>; Justin He (Arm Technology China) > <[email protected]>; nd <[email protected]> > Subject: Re: [PATCH v5 5/6] ptp: arm64: Enable ptp_kvm for arm64 > > On 15/10/19 12:48, Jianyong Wu wrote: > > +int kvm_arch_ptp_get_clock_generic(struct timespec64 *ts, > > + struct arm_smccc_res *hvc_res) { > > + u64 ns; > > + ktime_t ktime_overall; > > + > > + > arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FU > NC_ID, > > + hvc_res); > > + if ((long)(hvc_res->a0) < 0) > > + return -EOPNOTSUPP; > > + > > + ktime_overall = hvc_res->a0 << 32 | hvc_res->a1; > > + *ts = ktime_to_timespec64(ktime_overall); > > + > > + return 0; > > +} > > + > > This seems wrong, who uses kvm_arch_ptp_get_clock_fn? > This func used only by kvm_arch_ptp_get_clock and nothing to do with kvm_arch_ptp_get_clock_fn. Also it can be merged into kvm_arch_ptp_get_clock.
> Paolo
