On Sun, Jul 26, 2009 at 10:47 PM, Shiny<[email protected]> wrote:
>
>
> On 26/07/2009, at 22:32, "Adrian Lang" <[email protected]> wrote:
>
>> On Tue, July 21, 2009 11:06 pm, Craig Andrews wrote:
>>>
>>> helfire and I were just reviewing br3nda's merge request from
>>> http://gitorious.org/laconica/mainline/merge_requests/931 (Allow utf8
>>> alpha numerics in tags).
>>
>> Stripping dots (as well as hyphens) from tags is something we do for ages,
>> don‘t we?
>
>
> Yes it has been in common_canonical_tag() through several releases.
The code in common_canonical_tag() has stripped dot, hyphen, and
underscore for a long while -
return strtolower(str_replace(array('-', '_', '.'), '', $tag));
but the regex that detects the hashtag didn't include any or those
chars, so no dot, hyphen or underscore would have been sent to
common_canonical_tag().
Seems the intent was there at some stage to strip these, but it didn't happen.
_______________________________________________
Laconica-dev mailing list
[email protected]
http://mail.laconi.ca/mailman/listinfo/laconica-dev
