Bugs item #3526635, was opened at 2012-05-14 09:41 Message generated for change (Comment added) made by dnaber You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=655717&aid=3526635&group_id=110216
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: OpenOffice.org integration Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Stephan Bergmann (bergmann-rh) >Assigned to: Daniel Naber (dnaber) Summary: SingletonFactory should implement XServiceInfo Initial Comment: Since commit <http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2fd9b533cfad18735df212cc7fd61443628dc0c> "New cppu::defaultBootstrap_InitialComponentContext implementation" to LibreOffice master towards LibreOffice 3.6, adding LanguageTool.oxt to LibreOffice (via "Tools - Extension Manager... - Add..." or "unopkg add") would lead to a cryptic "Bad insert element" failure. The reason is that JLanguageTool's org.languagetool.openoffice.SingletonFactory does not implement XServiceInfo. Old LibreOffice versions silently ignored this problem (but live deployment of the extension did not work correctly -- e.g., "Tools - Langugage Tool - Configuration..." and "Tools - Language Tool - About..." would silently fail to display dialogs before a restart of LibreOffice). <http://cgit.freedesktop.org/libreoffice/core/commit/?id=3b1798a55bf7c193b911ce23e280e6a0e1e4314a> "Work around extension factories not implementing XServiceInfo" now makes LibreOffice master ignore the problematic factory during live deployment again, instead of making extension deployment fail. However, it would be better if the LanguageTool.oxt SingletonFactory properly implemented XServiceInfo, see the attached JLanguageTool-XServiceInfo.patch. (Using com.sun.star.lib.uno.helper.Factory.createComponentFactory instead of an own SingletonFactory unfortunately appears not possible, due to the large number of createInstance calls, which would lead to fresh instances with Factory.createComponentFactory, where SingletonFactory is careful to only create a single instance -- though that code is not properly synchronized.) ---------------------------------------------------------------------- >Comment By: Daniel Naber (dnaber) Date: 2012-05-15 15:13 Message: Thank you for the patch, I have just committed it so it will be in LT 1.8 (and upcoming daily snapshots, of course). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=655717&aid=3526635&group_id=110216 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Languagetool-cvs mailing list Languagetool-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-cvs
