On 02/12/2014 12:14 PM, Daniel Naber wrote: > On 2014-02-12 05:21, Andriy Rysin wrote: > >> It was really easy by overriding the getRuleFileNames() from Language >> class but I see that nobody else is doing that so I wanted to check >> first if anybody sees anything wrong with this approach. > I don't see anything wrong, but we might rely on "grammar.xml" as the > only file in some places. So it would be good if you could search the > source (including languagetool-community-website) to see if there are > such places that need fixing. > Quick search revealed less than a dozen references to grammar.xml in java files (not counting comments and printouts). Some of them are in tests and some of them are in langaugetool-standalone. It didn't look like those would be a problem but I can't tell for sure as I don't use standalone interface. This is probably what Marcin mentioned in his email, but I am not sure if loading the rules via user interface is something regular user would do...
Also community website referenced "grammar.xml" twice in message file, but no direct references in the code (at least I could not find it). Andriy ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
