So we have two options then: 1) move it to a parameter, but this is an option for the developer so I don't think this makes a lot of sense 2) remove it completely, but I think it would be nice to have in case somebody (maybe me again :)) will want to do more performance profiling
E.g. I used this property to test performance with different # of threads and if I didn't have it I would have to change the code every time. Also I'd like to use more threads than I have CPUs as it seems to have some performance improvement (albeit not huge), and property gives me a way to do it without affecting other users or recompiling the code. Also changing this parameter I was able to easily reproduce the problem with RuleGroupFilter failing on thread boundariess (I see different results when I switch between 4,5,6,7 threads). But if you feel strongly against it I can remove it. Andriy 2015-02-18 3:50 GMT-05:00 Daniel Naber <daniel.na...@languagetool.org>: > On 2015-02-18 00:15, Andriy Rysin wrote: > >> I don't have much explanation for this so I introduced a system >> property (org.languagetool.thread_count) if you want to force >> different # of threads. > > We don't use system properties anywhere else in the core code (only once > to get the temp directory, but that's a standard property). I'd suggest > to not introduce system properties. We don't have a place to document > them and this use case seems very exotic. > >> Unfortunately I would not be able to spend much more time analyzing >> performance for now so if we're ok with current changes in >> multithreading branch we should merge them into master. > > I'm okay with that. Thanks for the optimization work! > > Regards > Daniel > > > ------------------------------------------------------------------------------ > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & more > Get technology previously reserved for billion-dollar corporations, FREE > http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk > _______________________________________________ > Languagetool-devel mailing list > Languagetool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/languagetool-devel ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
