On 2015-02-19 22:16, Andriy Rysin wrote:

> I've merged multithreading branch into master. Please try it out when
> you have a chance and let me know if you see any issues.

Thanks. Some small cleanup ideas:

-setThreadPoolSize should probably be a parameter of the constructor, as 
calling it after thread pool setup would fail anyway ("Thread pool 
already initialized")
-Does newFixedThreadPool need to use lazy init? If it gets initialized 
in the constructor, it can also be made final.
-It can be 'threadPool' I think, no need for the 'new' and 'fixed' in 
the variable name.

Regards
  Daniel


------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Languagetool-devel mailing list
Languagetool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/languagetool-devel

Reply via email to