Well, the condition on overlapping wasn't changed, we only changed on
how many overlapping matches are removed.
So I guess in this case we either have to change the positions for
each bracket rule (so that they don't overlap, i.e. position for first
should not be 0-1 but 0-0) or give them different group ids.
BTW I just reverted my change to SameRuleGroupFilter and this sentence
still generates same 2 matches.
So it does not look like regression.
Andriy
2015-02-22 10:30 GMT-05:00 Jaume Ortolà i Font <jaumeort...@gmail.com>:
> 2015-02-22 15:04 GMT+01:00 Andriy Rysin <ary...@gmail.com>:
>>
>> No, the only thing I pushed that will lead to regressions was remove
>> more than one consequitive overlapping matches in SameRuleGroupFilter
>> (and also make sure we remove conequitive overlaps produced by
>> multiple threads). The regressions above seems to be all removals (the
>> other change would actually increase number of matches).
>> Could you please check if those are indeed extra consequitive
>> overlapping matches?
>
>
> Hi,
>
> In some cases there are overlapping matches that are removed. That's fine.
> But there are problems in sentences like this:
>
> ("This is a sentence)
>
> Previouly there were three matches for XX_UNPAIRED_BRACKETS rule: one on (,
> one on ", and one on ). Now the match on " is removed. So we are removing
> not only overlapping matches but also juxtaposed matches. I think these
> matches should not be removed.
>
> There are also overlapping rule matches where the start and end positions
> are not the same. I would not remove these matches. I'd prefer to remove
> only matches that coincide exactly at the start and at the end positions.
>
> Regards,
> Jaume
>
>
>
>
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
> _______________________________________________
> Languagetool-devel mailing list
> Languagetool-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/languagetool-devel
>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Languagetool-devel mailing list
Languagetool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/languagetool-devel
