Thanks, everyone!

We're going to unlock lps-3.3 for this change. Also, I've marked the  
lzc/lzc.bat bug that was reported yesterday as a 3.3.1 bug. Yossie's  
going to look at fixing it this afternoon, so let's hold off on  
starting a build until tonight. We can target a 3.3.1 release  
tomorrow end-of-day.

(Amy, can you send me revised release notes and change notes  
including the lzc/lzc.bat bug? Mamye's filing it now, you should be  
able to find it easily.)

jim

On May 31, 2006, at 10:37 AM, Max Carlson wrote:

> Philip Romanik wrote:
>> Change 42598 by [EMAIL PROTECTED] on 2006/05/30 19:45:10 *pending*
>>       Summary: Call update() when axis is changed in simplelayout.  
>> The 'onaxis' event is now generated as well. The last set of  
>> changes to set the off-axis to 0 have been removed.
>>       Bugs Fixed:
>>       LPP-2091 simplelayout axis=y on a view cancels the  
>> align=center of sub views on 3.3
>>       Technical Reviewer: XXX (pending)
>>       QA Reviewer: XXX (pending)
>>       Doc Reviewer: XXX (pending)
>>       Documentation:
>>          Backing out the changes to address LP-2091. Now, when you  
>> change the axis, the off-axis coordinates are not reset to zero.  
>> However, the off-axis coordinates are not reset at all; meaning  
>> that the previous values are maintained. If you dynamically change  
>> the axis, you are responsible for resetting the coordinates of the  
>> off-axis (See my test case below).
>>          I left the call to update() in the setAxis function so  
>> that the layout will automatically adjust. The code now calls the  
>> onaxis event, if one if specified. This is useful to reset the  
>> coordinates of the off-axis (See my test case below).
>> Test case:
>> <canvas height="600" debug="true">
>>   <view>
>>     <method event="onclick">
>>       sl.setAttribute ('axis', (sl.axis == "x") ? "y" : "x");
>>     </method>
>>     <simplelayout id="sl" axis="x" spacing="10">
>>       <method event="onaxis" args="axis">
>>         var offaxis = (axis == 'x') ? 'y' : 'x';
>>         v1.setAttribute(offaxis, 0);
>>         v2.setAttribute(offaxis, 0);
>>         v3.setAttribute(offaxis, 0);
>>       </method>
>>     </simplelayout>
>>     <view id="v1" bgcolor="blue" height="30" width="50"/>
>>     <view id="v2" bgcolor="blue" height="30" width="50"/>
>>     <view id="v3" bgcolor="blue" height="30" width="50"/>
>>   </view>
>> </canvas>
>> Affected files ...
>>       //depot/lps-3.3/lps/components/utils/layouts/ 
>> simplelayout.lzx     # edit
>>
>
> Approved!
>
> -- 
> Regards,
> Max Carlson
> OpenLaszlo.org

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to