Having trouble testing it, though. I have to *do* the runtime part of
it to see whether the compiler part of it fills my needs. (Visual
inspection of the output of lzc --script doesn't do it for me...) I
now have gotten started on the coal to trunk merge, which is having
some issues. I'd like to put off checking in this change until after
I submit a changeset for review for the coal to trunk integration. OR
delay the coal to trunk integration to after legals-pr3 branches. OR
I could fix the trunk to coal thing, make $style runtime work, and do
everything in the right order.
Well, that just answered itself. "Do everything in the right order."
Therefore, hang on on checking in this change, please.
-ben
On Aug 23, 2006, at 8:35 AM, P T Withington wrote:
> So... assign the compiler part to me, and, if you approve this
> change, I will check in and close the bug!
>
> On 2006-08-22, at 21:30 EDT, Benjamin Shine wrote:
>
>> Created as LPP-2539 and LPP-2540, compiler and runtime, both assigned
>> for me for now.
>>
>> We should have a mail-to-jira gateway that creates unclassified bugs.
>>
>> On Aug 22, 2006, at 2:40 PM, P T Withington wrote:
>>
>>> Well the new regime likes a bug for each check-in. Do you want to
>>> make one for me?
>>>
>>> On 2006-08-22, at 17:22 EDT, Benjamin Shine wrote:
>>>
>>>> I don't think there's one bug that does it -- it's part of
>>>> LPP-2309, and LPP-2510 is related.
>>>> It compiles ok (in coal) -- now I'll make some tests for it.
>>>>
>>>> BTW, Frisco is now the CSS doc guy.
>>>>
>>>> On Aug 22, 2006, at 12:11 PM, P T Withington wrote:
>>>>
>>>>> Change change.7sdt5h8wX.txt by [EMAIL PROTECTED] /Users/ptw/
>>>>> pending-changes/ on 2006-08-22 14:50:20 EDT
>>>>>
>>>>> Summary: Parse $style constraints
>>>>>
>>>>> New Features:
>>>>>
>>>>> <view height="$style{'height'}" width="$style{widthStyle}">
>>>>> <attribute name="widthStyle" value="'width'" />
>>>>> </view>
>>>>>
>>>>> will be parsed and generate an internal method `$style` with the
>>>>> following definition:
>>>>>
>>>>> function () { with (this) return {height: 'height', width:
>>>>> widthStyle}}
>>>>>
>>>>> which can be invoked by CSSApplyStyle to build the style map.
>>>>> Note
>>>>> that style constraints are expressions that will be evaluated
>>>>> in the
>>>>> instance's context, cf., the definition of width above.
>>>>>
>>>>> Bugs Fixed:
>>>>> [Ben: is there a bug number for this work?]
>>>>>
>>>>> Technical Reviewer: hminsky (pending)
>>>>> QA Reviewer: ben (pending)
>>>>> Doc Reviewer: adam (pending)
>>>>>
>>>>> Details:
>>>>> Add a new 'when' case `style`. Accumulate them in a map.
>>>>> Convert that map to a function that will return a Javascript
>>>>> hash
>>>>> representation of the map.
>>>>>
>>>>> Tests:
>>>>> Visually inspected the output of lzx --script
>>>>>
>>>>> Files:
>>>>> M src/org/openlaszlo/compiler/NodeModel.java
>>>>>
>>>>> <patch.ptw.M0Wo.tgz>
>>>>
>>>
>>
>> _______________________________________________
>> Laszlo-dev mailing list
>> [email protected]
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
>
_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
