I guess I don't understand the need for the style name indirection.
Doing this sort of evaluation adds complexity to the construct/init
sequence and forces certain kinds of code earlier into that sequence.
Can someone explain the use case?
(And by the way, this checkin resolves my confusion, expressed in
private correspondence over why the need to evaluate at all. I still
think it's potentially a bad idea, but I no longer think you want to
create CSS property values by looking up JavaScript variable bindings
at runtime.)
jim
On Aug 22, 2006, at 12:11 PM, P T Withington wrote:
> Change change.7sdt5h8wX.txt by [EMAIL PROTECTED] /Users/ptw/
> pending-changes/ on 2006-08-22 14:50:20 EDT
>
> Summary: Parse $style constraints
>
> New Features:
>
> <view height="$style{'height'}" width="$style{widthStyle}">
> <attribute name="widthStyle" value="'width'" />
> </view>
>
> will be parsed and generate an internal method `$style` with the
> following definition:
>
> function () { with (this) return {height: 'height', width:
> widthStyle}}
>
> which can be invoked by CSSApplyStyle to build the style map. Note
> that style constraints are expressions that will be evaluated in the
> instance's context, cf., the definition of width above.
>
> Bugs Fixed:
> [Ben: is there a bug number for this work?]
>
> Technical Reviewer: hminsky (pending)
> QA Reviewer: ben (pending)
> Doc Reviewer: adam (pending)
>
> Details:
> Add a new 'when' case `style`. Accumulate them in a map.
> Convert that map to a function that will return a Javascript hash
> representation of the map.
>
> Tests:
> Visually inspected the output of lzx --script
>
> Files:
> M src/org/openlaszlo/compiler/NodeModel.java
>
> <patch.ptw.M0Wo.tgz>
> _______________________________________________
> Laszlo-dev mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
