You can check it in if you promise that lzpix_cover.html (validates) [http://validator.w3.org/].
It would be nice to understand why the svn scripts are not working for you. And why the XXX in your change name was not replaced by the unique id... On 2006-08-25, at 17:24 EDT, Benjamin Shine wrote: > Tucker, can I check this in? The svn scripts aren't working well > for me with this change, so I'm including the diff of > lzpix_cover.html below; it just changes the jpg's for the buttons > to png's, and takes out explicit width/height for the "launch flash/ > launchdhtml" buttons. The rest of the change is deleting the jpg's > and adding the png's. > > Here's the diff: > Index: lzpix_cover.html > =================================================================== > --- lzpix_cover.html (revision 1653) > +++ lzpix_cover.html (working copy) > @@ -18,7 +18,7 @@ > <div style="margin: 10px"> > <img border="0" > src="images/cover-images/lzpix/lzpix.jpg" > alt="LZPIX Application" width="332" height="249"> > <div style="text-align: center"> > - <a title="Flash Version" > onclick="window.open(this.href, > '_blank', 'width=800,height=600'); return false" href="../../demos/ > lzpix/app-loader.html?lzr=swf7&lzt=html"><img src="images/cover- > images/lzpix/button-flash.jpg" alt="LZPIX Flash Version" > width="124" height="35" border="0"></a> <a title="DHTML Version" > onclick="window.open(this.href, '_blank', 'width=800,height=600'); > return false" href="../../demos/lzpix/app-loader.html? > lzr=dhtml&lzt=html"><img src="images/cover-images/lzpix/button- > dhtml.jpg" alt="LZPIX DHTML Version" width="129" height="35" > border="0"></a> > + <a title="Flash Version" > onclick="window.open(this.href, > '_blank', 'width=800,height=600'); return false" href="../../demos/ > lzpix/app-loader.html?lzr=swf7&lzt=html"><img src="images/cover- > images/lzpix/button-flash.png" alt="LZPIX Flash Version" > border="0"></a> <a title="DHTML Version" onclick="window.open > (this.href, '_blank', 'width=800,height=600'); return false" > href="../../demos/lzpix/app-loader.html? > lzr=dhtml&lzt=html"><img src="images/cover-images/lzpix/button- > dhtml.png" alt="LZPIX DHTML Version" border="0"></a> > </div> > </div> > </div> > > > And this is what it looks like now: > <Picture 16.png> > > > > On Aug 2, 2006, at 12:07 PM, P T Withington wrote: > >> The difffile is empty, so I can't see what you did to cover. >> >> This is not for pr2, correct? >> >> On 2006-08-02, at 14:03 EDT, Benjamin Shine wrote: >> >>> >>> laszlo-dev is holding this for review because the attachment is >>> too big -- can you just take a quick look and sign off please? >>> >>> Begin forwarded message: >>> >>>> From: Benjamin Shine <[EMAIL PROTECTED]> >>>> Date: August 2, 2006 10:51:23 AM PDT >>>> To: P T Withington <[EMAIL PROTECTED]>, Bret Simister >>>> <[EMAIL PROTECTED]> >>>> Cc: Laszlo-dev bug reporting <[email protected]> >>>> Subject: For Review: Change change.XXXXXXXXX.D5KnSKMG.txt >>>> Summary: Replaced images on lzpix explorer cover page with new art. >>>> >>>> Change change.XXXXXXXXX.D5KnSKMG.txt by [EMAIL PROTECTED] /Users/ >>>> ben/src/svn/openlaszlo/branches/legals/laszlo-explorer/ >>>> coverpages/ on 2006-08-02 10:44:26 PDT >>>> >>>> Summary: Replaced images on lzpix explorer cover page with new art. >>>> >>>> New Features: >>>> >>>> Bugs Fixed: LPP-2467 >>>> >>>> Technical Reviewer: ptw >>>> QA Reviewer: (pending) >>>> Doc Reviewer: (pending) >>>> >>>> Documentation: >>>> >>>> Release Notes: >>>> >>>> Details: >>>> Got new art from Bret. Width and height are slightly different >>>> from the old art, so I took out the explicit width/height from >>>> the html. >>>> >>>> >>>> Tests: >>>> Visually examined lzpix_cover.html and http://localhost:8080/ >>>> legals/laszlo-explorer/ >>>> >>>> Files: >>>> D images/cover-images/lzpix/button-dhtml.jpg >>>> A images/cover-images/lzpix/button-dhtml.png >>>> D images/cover-images/lzpix/button-flash.jpg >>>> A images/cover-images/lzpix/button-flash.png >>>> M lzpix_cover.html >>>> >> > _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
