1) Please file a bug for this:

> +// [2006-08-24 pbr] I can't call setFontName in dhtml, even though  
> there is
> +//                  a stub function because an error is generated,
> +//                     this.sprite.setFontName is not a function

The convention for comments associated with bugs is to label them  
FIXME and to not the bug number in parens.

// FIXME: [2006-08-24 pbr] (LPP-NNNN) ...

2) This:

>      // Install the default menu onto MovieClip, so it shows up  
> everywhere by default
> -    if (__LZDefaultCanvasMenu)
> -        MovieClip.prototype.menu =  
> __LZDefaultCanvasMenu.__LZcontextMenu();
> +    if (cproto.__LZDefaultCanvasMenu)
> +        MovieClip.prototype.menu =  
> cproto.__LZDefaultCanvasMenu.__LZcontextMenu();

would imply default canvas menus never worked.  Is there a bug on that?

3) Since LzText inherits from LzView, why do we need to duplicate  
SetFontName?

Otherwise, approved.

On 2006-08-25, at 17:25 EDT, Philip Romanik wrote:

> Change change.JufED3088.txt by [EMAIL PROTECTED] /tmp/ on 2006-08-25  
> 16:55:50 EDT
>
> Summary: Remove warnings from LFC. Update LzCanvas to new class system
>
> New Features:
>
> Bugs Fixed: LPP-2393 (partially)
>             LPP-2034 (partially)
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> Updated LzCanvas to the new class system. Also fixed a small class  
> issue in LzPlatform.as. The other changes remove warnings from lfc.
>
> Tests:
> lzpix, simple.lzx
>
> Files:
> M      LzScript.lzs
> M      LzText.lzs
> M      platform\swf\LzPlatform.as
> M      LaszloView.lzs
> M      LaszloCanvas.lzs
> <patch.Philip.4288.tgz>

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to