Good catch! The change looks good. Please check in the test file in
/test/lps/lztrack/... ideally with some text on the canvas that says
what to look for.
Sarah
On Tue, Nov 21, 2006 at 6:08 PM, Adam Wolff wrote:
Summary: Here's a quick fix for LzTrack in trunk. The old code
referred to view's
"depth" property, which has been renamed to __LZdepth. The enclosed
testcase shows the bug and is corrected by the fix.
New Features:
Bugs Fixed:
(No bug number -- see enclosed testcase)
Technical Reviewer: sarah allen(pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
Code in LzTrack had rotted
Tests:
brokenTrack.lzx (not for checkin)
Files:
WEB-INF/lps/lfc/services/LzTrack.as
svn diff services/LzTrack.as
Index: services/LzTrack.as
===================================================================
--- services/LzTrack.as (revision 2409)
+++ services/LzTrack.as (working copy)
@@ -127,7 +127,7 @@
btemp = btemp.immediateparent;
}
// a and b are siblings, check depth
- if (atemp.depth > btemp.depth) return a;
+ if (atemp.__LZdepth > btemp.__LZdepth) return a;
else return b;
}