There's a bug in my XSL code that isn't passing the width/height
through properly. I wish I could say it was hidden by the issues
resolved in Max's change here, but that might a little too self-
serving :-)
I'll try to have a patch ready for review tomorrow.
jim
On Mar 7, 2007, at 4:50 PM, J Crowley wrote:
Whoo! Approved!
(Though, I should probably fix some of the canvas sizes on the
charting examples now...)
On Mar 7, 2007, at 4:44 PM, Max Carlson wrote:
Change 20070307-maxcarlson-r by [EMAIL PROTECTED]
computer.local on 2007-03-07 13:31:27 PST
in /Users/maxcarlson/openlaszlo/legals-clean
Summary: Improve swf and dhtml embedding usability
New Features: The optional appenddivid property can be passed in
to swfEmbed() or dhtmlEmbed() to specify the id of a div whose
contents should be replaced with the embed. If a div with that ID
doesn't exist, one will be written into the document where swf/
dhtmlEmbed() is called. If appenddivid is not specified, the div
written will be based on the id property + 'Container'.
Bugs Fixed: LPP-3661 - Canvas value not being passed into
surrounding div in docs.
Technical Reviewer: jgrandy
QA Reviewer: jcrowley
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: LzSprite.js - Refactor div creation logic to Lz.dhtmlEmbed()
app-console.xslt - Remove lzOptions.appendDivID, instead passing
in appenddivid argument for embeds.
js2doc-comment2dbk.xsl, format.xsl, doc2dbk.xsl - Quote height and
width values rather than using bogus toString() method, which was
returning the window object.
docbook.css - set margin-top: -5px; for refsect1 div, rather than
hacking h1..6
styles.css - Avoid hacking h1..6 margins
embednew.js - Moved logic for determining which div is written to
from flash.js and LzSprite.js to _getAppendDiv(). _getAppendDiv()
is called by swf/dhtmlEmbed() to determine which div should be
written to.
flash.js - Pass appenddiv argument to write() method.
dev-console.lzx.js - Rebuild with new sprite, so it's placed
properly.
Test : ant doc now shows examples correctly inline at the proper
sizes. All other applications run as before. swf/dhtmlEmbed()
should be more usable now.
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M WEB-INF/lps/templates/app-console.xslt
M docs/src/xsl/js2doc-comment2dbk.xsl
M docs/src/xsl/format.xsl
M docs/src/xsl/doc2dbk.xsl
M docs/includes/docbook.css
M docs/includes/styles.css
M lps/includes/source/embednew.js
M lps/includes/source/flash.js
M lps/admin/dev-console.lzx.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070307-
maxcarlson-r.tar
