I'd like to add this to the top of
http://svn.openlaszlo.org/tools/trunk/svn/README.txt or somewhere. I
got a bit confused on #7, perhaps some experienced committer or reviewer
could advise. I've got a few small changes queued up and I want to make
sure I've got the process right...
STEPS TO SUBMITTING A CHANGE:
1) cd $MYSVNHOME/tools/trunk/svn
2) source svn-bash.sh
3) cd to where your changes are
this can any svn directory and it'll make a changeset for all changes in
subdirectories
4) svn-newchange
5) svn-editchange: fill in the change template with details on what you
did
6) svn-review: mail the output to openlaszlo-dev
7) if there is feedback from the review, should you svn-review again? or
is it ok to just svn-commit if the changes are small? I thought the
latter, but maybe I was presumptuous, because when I then did svn-commit
I only committed my changed file, not the whole changeset
8) svn-editchange: don't forget to include who did the code review!
9) svn-commit
p.s. how do you change the editor that svn-editchange wants to use? I
think my UTF-8 problem was that it was opening some ancient vi in cygwin
and I accidentally added some control characters into the change notes.
I'd be much happier if I could get it to open vim.
Thanks,
Sarah
