On 2007-03-18, at 23:12 EDT, Sarah Allen wrote:
I'd like to add this to the top of http://svn.openlaszlo.org/tools/
trunk/svn/README.txt or somewhere. I got a bit confused on #7,
perhaps some experienced committer or reviewer could advise. I've
got a few small changes queued up and I want to make sure I've got
the process right...
I will add this. I have updated the README a bunch, but something in
svn is preventing me from checking it in! (And we have bigger fish
to fry just now.)
STEPS TO SUBMITTING A CHANGE:
1) cd $MYSVNHOME/tools/trunk/svn
2) source svn-bash.sh
3) cd to where your changes are
this can any svn directory and it'll make a changeset for all
changes in subdirectories
4) svn-newchange
Not necessary if you don't have any changes yet, as 5 will make a new
change if you don't specify one.
5) svn-editchange: fill in the change template with details on what
you did
6) svn-review: mail the output to openlaszlo-dev
7) if there is feedback from the review, should you svn-review
again? or is it ok to just svn-commit if the changes are small? I
thought the latter, but maybe I was presumptuous, because when I
then did svn-commit I only committed my changed file, not the whole
changeset
Our discipline is if someone "approves with comments" you may check
in after addressing the comments. If the reviewer really thinks you
got it wrong, they say "not approved", in which case a re-review is
expected before check in.
Something that may not be obvious: Once you say new change, it gets
the modified files at that point. If you modify more files later,
you will have to manually add them to the changeset (or discard your
change and start over). After new change, the whole process is
driven by the list of files in the change description.
8) svn-editchange: don't forget to include who did the code review!
Always a good practice. I also say how they reviewed, just to be a
pedant. I usually nominate reviewers, by naming them in the change
before I send it for review (they are more likely to volunteer then).
9) svn-commit
Which you must do from the directory you made the change in, or your
files will not be found.
p.s. how do you change the editor that svn-editchange wants to
use? I think my UTF-8 problem was that it was opening some ancient
vi in cygwin and I accidentally added some control characters into
the change notes. I'd be much happier if I could get it to open vim.
It takes it from your shell $EDITOR variable. This is part of the
revised doc I would like to check in...
