Re: [Laszlo-dev] For Review: Change 20070817-ptw-3 Summary: Remove `make` trampoline from Class system

[Max Carlson]

Approved!

P T Withington wrote:

Change 20070817-ptw-3 by [EMAIL PROTECTED] on 2007-08-17 07:12:53 EDT

    in /Users/ptw/OpenLaszlo/wafflecone
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: Remove `make` trampoline from Class system

Bugs Fixed:
LPP-1605 'ctor precedence is wrong'
LPP-4365 'Adding prototype functions to builtin objects a bit broken'
LPP-4513 'Compiler Improvements to address performance'

Technical Reviewer: max (pending)
QA Reviewer: hminsky (pending)

Details:
    LzDefs: Rework LzInheritedHash to not require .make.

    Class: Rework contstructors to call .initialize, .make retained
    for backwards-compatibility.  Split out class validation code.

    Compiler: Remove passThroughNodes before dispatching.  Print new
    expressions with correct associativity.

    JavascriptGenerator, JavascriptCompressor, CodeGenerator: Remove
    translation of new to .make

    Parser.jjt: Learn how to correctly parse a `new` expressions and
    maintain associativity.

Tests:
    smokecheck in swf7, swf8, dhtml

Files:
M      WEB-INF/lps/lfc/core/LzDefs.lzs
M      WEB-INF/lps/lfc/compiler/Class.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptCompressor.java
M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070817-ptw-3.tar

--
Regards,
Max Carlson
OpenLaszlo.org