Interesting. The only calls to make now should be from the creation
of a class. So... that means there are 333 classes in your test
case. Yow!
On 2007-08-17, at 20:06 EDT, Max Carlson wrote:
Here are the top 10 with r6132:
% cumulative self calls self total
name index
time seconds seconds ms/call ms/call
122.9% 0.59 0.59 333 1.79 1.90
LzCSSStyle.getPropertyValueFor [15]
121.3% 1.18 0.59 1889 0.31 2.67
initialize [1]
76.9% 1.55 0.37 2084 0.18 0.25
register [20]
67.7% 1.88 0.33 1847 0.18 2.98
make [0]
49.8% 2.12 0.24 677 0.36 1.78
__LZapplyArgs [9]
49.7% 2.36 0.24 330 0.73 0.88
classInit [27]
35.4% 2.53 0.17 525 0.33 2.27
applyConstraint [10]
33.5% 2.70 0.16 6306 0.03 0.03
AddProperty [40]
30.7% 2.84 0.15 679 0.22 0.85
construct [19]
29.8% 2.99 0.14 171 0.84 1.71
__LZstoreDelegates [26]
And after with r6134:
% cumulative self calls self total
name index
time seconds seconds ms/call ms/call
195.6% 0.60 0.60 333 1.80 1.87
LzCSSStyle.getPropertyValueFor [14]
151.4% 1.06 0.46 1887 0.25 2.37
initialize [1]
100.6% 1.37 0.31 2084 0.15 0.18
register [23]
78.2% 1.61 0.24 677 0.35 1.57
__LZapplyArgs [9]
62.1% 1.80 0.19 6306 0.03 0.03
AddProperty [32]
58.6% 1.98 0.18 525 0.34 1.96
applyConstraint [10]
54.7% 2.14 0.17 330 0.51 0.65
classInit [30]
50.0% 2.30 0.15 679 0.23 0.70
construct [19]
38.4% 2.42 0.12 171 0.69 1.26
__LZstoreDelegates [29]
38.1% 2.53 0.12 333 0.35 1.29
make [20]
That's 1514 fewer calls to make()!
P T Withington wrote:
Checked in as r6134.
I would be interested in your profile results with this in.
On 2007-08-17, at 19:09 EDT, Max Carlson wrote:
Approved!
P T Withington wrote:
Change 20070817-ptw-3 by [EMAIL PROTECTED] on 2007-08-17
07:12:53 EDT
in /Users/ptw/OpenLaszlo/wafflecone
for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
Summary: Remove `make` trampoline from Class system
Bugs Fixed:
LPP-1605 'ctor precedence is wrong'
LPP-4365 'Adding prototype functions to builtin objects a bit
broken'
LPP-4513 'Compiler Improvements to address performance'
Technical Reviewer: max (pending)
QA Reviewer: hminsky (pending)
Details:
LzDefs: Rework LzInheritedHash to not require .make.
Class: Rework contstructors to call .initialize, .make retained
for backwards-compatibility. Split out class validation code.
Compiler: Remove passThroughNodes before dispatching. Print
new
expressions with correct associativity.
JavascriptGenerator, JavascriptCompressor, CodeGenerator:
Remove
translation of new to .make
Parser.jjt: Learn how to correctly parse a `new` expressions
and
maintain associativity.
Tests:
smokecheck in swf7, swf8, dhtml
Files:
M WEB-INF/lps/lfc/core/LzDefs.lzs
M WEB-INF/lps/lfc/compiler/Class.lzs
M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/
JavascriptGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/
JavascriptCompressor.java
M WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070817-
ptw-3.tar
--
Regards,
Max Carlson
OpenLaszlo.org
--
Regards,
Max Carlson
OpenLaszlo.org
