This has caused some svn errors on the nightly build servers.

Mamye


  ----- Original Message ----- 
  From: Henry Minsky 
  To: Max Carlson ; Laszlo-dev bug reporting 
  Sent: Wednesday, October 31, 2007 8:14 AM
  Subject: Re: [Laszlo-dev] for review, Change 20071028-hqm-6,put XML parser 
back into server data proxy pipeline,to do charset transcoding


  Yes, Tomcat sends the output as "chunked" when LPS is proxying a 1.6 MB data 
file with this patch. 



  On 10/31/07, Henry Minsky < [EMAIL PROTECTED]> wrote:
    Note, that this code does not know the content length before it starts 
writing the output to 
    the client, since it's being streamed.  So it doesn't set the content 
length explicitly, like it used to.

    My understanding of Tomcat's behavior is that if the content is small 
enough to fit in some tomcat output 
    buffer size , it will buffer it and then send it all with a content length 
header. If it is larger than that
    then Tomcat sends it in HTTP chunked encoding. I still have to verify this 
with a very large file. 




    On 10/28/07, Henry Minsky <[EMAIL PROTECTED] > wrote:
      Change 20071028-hqm-6 by [EMAIL PROTECTED] on 2007-10-28 20:42:12 EDT
          in /cygdrive/c/users/hqm/openlaszlo/trunk
          for http://svn.openlaszlo.org/openlaszlo/trunk 

      Summary: put XML parser back into server data proxy pipeline, to do
      charset transcoding

      New Features:

      Bugs Fixed: LPP-4924

      Technical Reviewer: max
      QA Reviewer: pablo
      Doc Reviewer: 

      Details:

      The server data proxy now uses the XMLPULL parser to parse
      the data from the backend, in order to use Java to force a translation
      into UTF-8
      coding if needed.

      This change also uses a worker Thread to read from the backend, while 
      simultaneously
      pipelining the data back throug the XML PULL parser to the client.
      This should improve
      response time and also removes a potential memory overflow and DOS
      attack on the server.

      Tests: 

      test/lfc/data/alldata.lzx
      amazon
      calendar


      Files:
      D      WEB-INF/lib/xpp3-1.1.3.4d_b4.jar
      A      WEB-INF/lib/xpp3-1.1.4c.jar
      M      WEB-INF/lps/lfc/kernel/swf/LzLoadQueue.as
      A      WEB-INF/lps/server/src/org/openlaszlo/data/HttpData.java 
      M      WEB-INF/lps/server/src/org/openlaszlo/data/XMLGrabber.java
      M      WEB-INF/lps/server/src/org/openlaszlo/data/HTTPDataSource.java
      M      WEB-INF/lps/server/src/org/openlaszlo/data/DataSource.java



      --
      Henry Minsky
      Software Architect
      [EMAIL PROTECTED]




    -- 
    Henry Minsky
    Software Architect
    [EMAIL PROTECTED]





  -- 
  Henry Minsky
  Software Architect
  [EMAIL PROTECTED]

Reply via email to