Re: [Laszlo-dev] for review, Change 20071028-hqm-6, put XML parser back into server data proxy pipeline, to do charset transcoding

[Max Carlson]

Approved!

Henry Minsky wrote:

Change 20071028-hqm-6 by [EMAIL PROTECTED] on 2007-10-28 20:42:12 EDT
    in /cygdrive/c/users/hqm/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: put XML parser back into server data proxy pipeline, to do
charset transcoding

New Features:

Bugs Fixed: LPP-4924

Technical Reviewer: max
QA Reviewer: pablo
Doc Reviewer:

Details:

The server data proxy now uses the XMLPULL parser to parse
the data from the backend, in order to use Java to force a translation
into UTF-8
coding if needed.

This change also uses a worker Thread to read from the backend, while
simultaneously
pipelining the data back throug the XML PULL parser to the client.
This should improve
response time and also removes a potential memory overflow and DOS
attack on the server.

Tests:

test/lfc/data/alldata.lzx
amazon
calendar


Files:
D      WEB-INF/lib/xpp3-1.1.3.4d_b4.jar
A      WEB-INF/lib/xpp3-1.1.4c.jar
M      WEB-INF/lps/lfc/kernel/swf/LzLoadQueue.as
A      WEB-INF/lps/server/src/org/openlaszlo/data/HttpData.java
M      WEB-INF/lps/server/src/org/openlaszlo/data/XMLGrabber.java
M      WEB-INF/lps/server/src/org/openlaszlo/data/HTTPDataSource.java
M      WEB-INF/lps/server/src/org/openlaszlo/data/DataSource.java

--
Regards,
Max Carlson
OpenLaszlo.org