On 2008-03-13, at 17:43 EDT, Henry Minsky wrote:
I haven't done the global search and replace yet for ' instanceof
tagname' and 'new tagname()' but I came across a couple of
issues:
There's a bug with the debugger, dragging or stretching it gives
lzx> DEBUG @debugger/newcontent.lzx#238: Bad constraint
{_dbg_typename: LzConstraintExpr, ..., methodName: $lzc$bind_y,
classname: Object, ...} on .dragger
ERROR @debugger/newcontent.lzx#238: .dragger.applyConstraintMethod:
invalid arguments [$lzc$bind_y, null]
DEBUG @debugger/newcontent.lzx#238: Bad constraint {_dbg_typename:
LzConstraintExpr, ..., methodName: $lzc$bind_y, classname: Object,
...} on .dragger
ERROR @debugger/newcontent.lzx#238: .dragger.applyConstraintMethod:
invalid arguments [$lzc$bind_y, null]
WARNING: Sent extra global mouse event
This looks like there is some work to do in states (again). Max has
seen another issue where the state code is trying to call a method
that is now obsolete. This is going to be tricky, because of the
issue of states trying to move methods from one object to another at
run time (which we know we can't do in JS2).
I'm looking for other issues ... the
examples/components/style_example.lzx also gives some errors in the
debugger
tabclass 'null' is undefined
This is surely a missing `lz.` causing the class not to be found, and
probably causes a bunch of the succeeding errors. If you go through
the examples and fix up the class refs, you will probably have better
success
WARNING @base/basetabs.lzx#363: reference to undefined property
'selected'
ERROR @base/basetabs.lzx#364: call to undefined method 'setAttribute'
tabclass 'null' is undefined
tabclass 'null' is undefined
ERROR: ._windowResize.__LZaddSetter is no longer supported
INFO @base/resizeview.lzx#25: .leftview.applyConstraint is deprecated.
Use .leftview.applyConstraintMethod instead
INFO @base/resizeview.lzx#31: .middleview.applyConstraint is
deprecated. Use .middleview.applyConstraintMethod instead
INFO @base/resizeview.lzx#37: .rightview.applyConstraint is
deprecated. Use .rightview.applyConstraintMethod instead
IWBN to update the applyConstraint's to applyConstraintMethod's (which
might mean moving the constraint from a closure to a method on the
appropriate class).
On Thu, Mar 13, 2008 at 3:17 PM, P T Withington <[EMAIL PROTECTED]> wrote:
[UPDATE: placement is working now]
Change 20080313-ptw-5 by [EMAIL PROTECTED] on 2008-03-13
10:54:50 EDT
in /Users/ptw/OpenLaszlo/ringding-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: LZX classes as JS2 classes
New Features: The tag compiler now emits LZX classes as JS2 class
declarations
Bugs Fixed:
LPP-1587 'ECMA4: Compile LZX declarations as JS
declarations' (partial)
Technical Reviewer: [EMAIL PROTECTED] (pending)
QA Reviewer: [EMAIL PROTECTED] (pending)
Doc Reviewer: [EMAIL PROTECTED] (pending)
Documentation: TBD
Release Notes: TBD
Details:
Highlights: The tag compiler now emits user classes as a JS2
class declaration. UserClass.lzs is dead. Setters are now just
methods on a class with a distinctive name, so the whole setters
table inheritance mechanism is gone. Early/delayed setters is a
private protocol between LzNode and LzView. All classes have a
uniorm 'namespace' naming scheme: $lzc$class_<tagname>, old LFC
class names are maintained for compatibility, but there are NO
global class names any more. All user code will have to be
updated to use lz.<tagname> to address classes for `new` or
`instanceof` tests.
[Details TBD]
Tests:
smokecheck has one failure regarding placement, amazon fails in
dhtml, I suspect due to the placement problem.
Files:
M test/smoke/regression.lzl
M test/smoke/all_setters.lzl
M test/smoke/getters-setters.lzl
M test/attribute-override-1.lzx
M WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs
M WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js
M WEB-INF/lps/lfc/kernel/swf9/LzLibrary.lzs
M WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/core/UserClass.lzs
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzScript.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
M WEB-INF/lps/lfc/helpers/LzCommand.lzs
M WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
M WEB-INF/lps/lfc/helpers/LzState.lzs
M WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
M WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
M WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
M WEB-INF/lps/lfc/data/LzReplicationManager.lzs
M WEB-INF/lps/lfc/data/platform/swf/LzConnectionDatasource.lzs
M WEB-INF/lps/lfc/data/platform/swf/LzConnection.lzs
M WEB-INF/lps/lfc/data/LzDatapointer.lzs
M WEB-INF/lps/lfc/data/LzDataText.lzs
M WEB-INF/lps/lfc/data/LzDataRequest.lzs
M WEB-INF/lps/lfc/data/LzDataElement.lzs
M WEB-INF/lps/lfc/data/LzDataProvider.lzs
M WEB-INF/lps/lfc/data/LzDataset.lzs
M WEB-INF/lps/lfc/data/LzDatapath.lzs
M WEB-INF/lps/lfc/data/LzHTTPDatasource.lzs
M WEB-INF/lps/lfc/data/LzParam.lzs
M WEB-INF/lps/lfc/compiler/Class.lzs
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/Schema.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/
JavascriptGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/ScriptCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/ScriptClass.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/
ClassCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M lps/components/queens-charts/barchart.lzx
M lps/components/queens-charts/linechart.lzx
M lps/components/queens-charts/shared/dataseries.lzx
M lps/components/queens-charts/shared/basechartbacking.lzx
M lps/components/queens-charts/shared/basechart.lzx
M lps/components/queens-charts/shared/wholepie.lzx
M lps/components/queens-charts/shared/legend.lzx
M lps/components/queens-charts/piechart.lzx
M lps/components/rpc/rpc.lzx
M lps/components/rpc/xmlrpc.lzx
M lps/components/debugger/newcontent.lzx
M lps/components/debugger/scrollingtext.lzx
M lps/components/charts/common/dataseries.lzx
M lps/components/charts/common/chart.lzx
M lps/components/incubator/fisheye_lib.lzx
M lps/components/incubator/gradientview.lzx
M lps/components/incubator/autocompletecombobox.lzx
M lps/components/incubator/test/tooltipmanager-test.lzx
M lps/components/incubator/opttree/opttree.lzx
M lps/components/incubator/colorpicker.lzx
M lps/components/incubator/tooltipmanager.lzx
M lps/components/incubator/baseradio.lzx
M lps/components/incubator/rich-text/test/richtexteditarea-
test.lzx
M lps/components/incubator/rich-text/linkdialog.lzx
M lps/components/incubator/validators/validatingForm.lzx
M lps/components/incubator/validators/basevalidator.lzx
M lps/components/incubator/uploader/example/test-
fileuploadlist.lzx
M lps/components/incubator/uploader/example/test-
multiplefileupload.lzx
M lps/components/incubator/uploader/multiplefileupload.lzx
M lps/components/extensions/av/mediastream.lzx
M lps/components/extensions/av/videoview.lzx
M lps/components/extensions/av/rtmpconnection.lzx
M lps/components/base/basescrollbar.lzx
M lps/components/base/swatchview.lzx
M lps/components/base/basetree.lzx
M lps/components/base/componentmanager.lzx
M lps/components/base/basecomponent.lzx
M lps/components/base/basetabslider.lzx
M lps/components/base/baselist.lzx
M lps/components/base/basegrid.lzx
M lps/components/base/basetabs.lzx
M lps/components/base/basedatacombobox.lzx
M lps/components/base/style.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080313-ptw-5.tar
--
Henry Minsky
Software Architect
[EMAIL PROTECTED]
