This doesn't look right to me:
1) The n-levels of closure that are introduced to make the IE native
functions behave should not be imposed on other browsers. We need to
conditionalize that code using Max's features feature.
2) The work-around makes the interval and timeout functions be
Functions, so you _can_ apply them, but you are no longer applying
them. It seems to me the arguments are going to be passed as an
array, which is not what is expected.
3) Presumably you need to wrap the clear* native functions also?
On 2008-05-06, at 10:39 EDT, Philip Romanik wrote:
Change 20080506-Philip-0 by [EMAIL PROTECTED] on 2008-05-06 10:26:51
EDT
in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk_clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix most IE7/dhtml dragging issues in lzpix
New Features:
Bugs Fixed: LPP-5926
Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
Calling window.setInterval.apply() and window.setTimeout.apply()
does not work in IE6/IE7. I found a workaround online that presents
a fix: http://webreflection.blogspot.com/2007/06/simple-settimeout-setinterval-extra.html
Also, running lzpix in debug mode is failing because of javascript
library, md5 that is loaded. Andre found that if this is loaded
immediately, the compiled file does not have named functions.
Tests:
lzpix runs in dhtml in IE6/IE7 as well as other browsers. It also
runs when debugging is enabled.
In IE6/IE7 dragging a single image to the clips is not shown, and
image is not displayed in the clips until another image is dragged.
Dragging multiple images works except that 1 fewer image is shown
being dragged. LPP-5937 is created for this.
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzTimeKernel.js
M demos/lzpix/classes/dataman.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080506-Philip-0.tar
