I _really_ don't think you want 'null' as the first argument to
apply. It should be the object that you want to be 'this' in the
method. Maybe you don't need 'this' in this case, but:
a) It looks really weird, and unless you have some special reason for
doing it, let's not. Just say:
window.setTimeout.apply(window, arguments);
b) In some JS1's passing null as the first argument to apply will
cause 'this' to be bound to the global object. If that's really what
you are intending here, you ought to be explicit.
On 2008-05-06, at 14:46 EDT, Max Carlson wrote:
It seems like the window.setInterval/setTimeout() hacks should be
restricted to IE only. Also, it seems like this won't pass the
right arguments:
return window.setTimeout(null, arguments);
Perhaps you meant this:
return window.setTimeout.apply(null, arguments);
Philip Romanik wrote:
Change 20080506-Philip-0 by [EMAIL PROTECTED] on 2008-05-06 10:26:51
EDT
in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk_clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix most IE7/dhtml dragging issues in lzpix
New Features:
Bugs Fixed: LPP-5926
Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
Calling window.setInterval.apply() and window.setTimeout.apply()
does not work in IE6/IE7. I found a workaround online that presents
a fix: http://webreflection.blogspot.com/2007/06/simple-settimeout-setinterval-extra.html
Also, running lzpix in debug mode is failing because of javascript
library, md5 that is loaded. Andre found that if this is loaded
immediately, the compiled file does not have named functions.
Tests:
lzpix runs in dhtml in IE6/IE7 as well as other browsers. It also
runs when debugging is enabled.
In IE6/IE7 dragging a single image to the clips is not shown, and
image is not displayed in the clips until another image is dragged.
Dragging multiple images works except that 1 fewer image is shown
being dragged. LPP-5937 is created for this.
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzTimeKernel.js
M demos/lzpix/classes/dataman.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080506-Philip-0.tar
--
Regards,
Max Carlson
OpenLaszlo.org
