Re: [Laszlo-dev] For Review: Change 20080521-maxcarlson-e Summary: UPDATED - Change 20080521-ptw-z Summary: Rename `ConstructorMap` to `lz`, don't clobber `lz` if it already exists.

[Philip Romanik]

Approved. This runs as well for me as the last changeset but I see 
where you fixed some issues. I don't know why I didn't see them when I tested.

Change 20080521-maxcarlson-e by [EMAIL PROTECTED] on 2008-05-21
15:41:59 PDT
     in /Users/maxcarlson/openlaszlo/trunk-clean
     for 
<http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED - Change 20080521-ptw-z Summary: Rename 
`ConstructorMap` to `lz`, don't clobber `lz` if it already exists.

Bugs Fixed:
LPP-6020 'DHTML compiler should check to see if window.lz hash is 
defined before overwriting it.'

Technical Reviewer: ptw (pending)
QA Reviewer: promanik (pending)

Release Notes:

Details:
(from PTW)
     *: ConstructorMap -> lz

     LzDefs: Remove private ConstructorMap.  Don't create a hash in lz
     if it already exists.

     LaszloInitiator: Remove stale comment.

     ParseTreePrinter: Define missing 'is' operator in op table,
     discovered while developing this patch.

Also I discovered a missing ConstructorMap -> lz in LzDataProvider 
and CanvasCompiler, and a typo in LaszloCanvas that was failing to 
look up LzUtils.

Tests:
     ant lztest, smokecheck, lzpix in dhtml and swf8 run with and 
without the debugger.

Files:
M      WEB-INF/lps/lfc/core/LzNode.lzs
M      WEB-INF/lps/lfc/core/LzDefs.lzs
M      WEB-INF/lps/lfc/glue/LaszloInitiator.lzs
M      WEB-INF/lps/lfc/views/LzInputText.lzs
M      WEB-INF/lps/lfc/views/LzScript.lzs
M      WEB-INF/lps/lfc/views/LzText.lzs
M      WEB-INF/lps/lfc/views/LaszloView.lzs
M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M      WEB-INF/lps/lfc/helpers/LzCommand.lzs
M      WEB-INF/lps/lfc/helpers/LzState.lzs
M      WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
M      WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
M      WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
M      WEB-INF/lps/lfc/data/LzDatapointer.lzs
M      WEB-INF/lps/lfc/data/LzDataRequest.lzs
M      WEB-INF/lps/lfc/data/LzDataProvider.lzs
M      WEB-INF/lps/lfc/data/LzDataset.lzs
M      WEB-INF/lps/lfc/data/LzDatapath.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/
CanvasCompiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
M      lps/admin/dev-console.lzx.js

Changeset: 
<http://svn.openlaszlo.org/openlaszlo/patches/20080521-maxcarlson-e.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080521-maxcarlson-e.tar