Ok, thanks.
Max, were you unpacking the files or trying to apply the diffs?
I just checked out a clean sandbox and then unpacked the files into it
and it builds fine and lztest runs fine. Since Phil and I test fine,
I suspect something awry in Max's "clean" playpen. I should note,
that I made sure that I unpacked the files into a playpen that was at
the same revision as the change. I'm guessing that Max did an unpack,
but may have unpacked into a playpen that was at a different revision,
so got a skew in the files.
I am going to check in my version and see if that gets Max back on
track.
On 2008-05-22, at 09:36 EDT, Philip Romanik wrote:
Here is a clue. Your original changeset includes a change in
LzDataProvider.lzs. Max's updated changeset said he found a
ConstructorMap reference in LzDataProvider, but this change is in
your original changeset. It appears as though part of your changeset
didn't apply when Max ran it.
The other 2 changes from Max address deprecations.
I'd like to figure out why Max is seeing errors and Phil and I are
not before accepting this change.
On 2008-05-21, at 21:27 EDT, Philip Romanik wrote:
> Approved. This runs as well for me as the last changeset but I see
> where you fixed some issues. I don't know why I didn't see them
when I
> tested.
>
>
>> Change 20080521-maxcarlson-e by [EMAIL PROTECTED] on 2008-05-21
>> 15:41:59 PDT
>> in /Users/maxcarlson/openlaszlo/trunk-clean
>> for <<http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: UPDATED - Change 20080521-ptw-z Summary: Rename
>> `ConstructorMap` to `lz`, don't clobber `lz` if it already exists.
>>
>> Bugs Fixed:
>> LPP-6020 'DHTML compiler should check to see if window.lz hash is
>> defined before overwriting it.'
>>
>> Technical Reviewer: ptw (pending)
>> QA Reviewer: promanik (pending)
>>
>> Release Notes:
>>
>> Details:
>> (from PTW)
>> *: ConstructorMap -> lz
>>
>> LzDefs: Remove private ConstructorMap. Don't create a hash
in lz
>> if it already exists.
>>
>> LaszloInitiator: Remove stale comment.
>>
>> ParseTreePrinter: Define missing 'is' operator in op table,
>> discovered while developing this patch.
>>
>> Also I discovered a missing ConstructorMap -> lz in LzDataProvider
>> and CanvasCompiler, and a typo in LaszloCanvas that was failing to
>> look up LzUtils.
>>
>> Tests:
>> ant lztest, smokecheck, lzpix in dhtml and swf8 run with and
>> without the debugger.
>>
>> Files:
>> M WEB-INF/lps/lfc/core/LzNode.lzs
>> M WEB-INF/lps/lfc/core/LzDefs.lzs
>> M WEB-INF/lps/lfc/glue/LaszloInitiator.lzs
>> M WEB-INF/lps/lfc/views/LzInputText.lzs
>> M WEB-INF/lps/lfc/views/LzScript.lzs
>> M WEB-INF/lps/lfc/views/LzText.lzs
>> M WEB-INF/lps/lfc/views/LaszloView.lzs
>> M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
>> M WEB-INF/lps/lfc/helpers/LzCommand.lzs
>> M WEB-INF/lps/lfc/helpers/LzState.lzs
>> M WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
>> M WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
>> M WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
>> M WEB-INF/lps/lfc/data/LzDatapointer.lzs
>> M WEB-INF/lps/lfc/data/LzDataRequest.lzs
>> M WEB-INF/lps/lfc/data/LzDataProvider.lzs
>> M WEB-INF/lps/lfc/data/LzDataset.lzs
>> M WEB-INF/lps/lfc/data/LzDatapath.lzs
>> M WEB-INF/lps/server/src/org/openlaszlo/sc/
ParseTreePrinter.java
>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/
>> CanvasCompiler.java
>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/
NodeModel.java
>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/
ClassModel.java
>> M lps/admin/dev-console.lzx.js
>>
>> Changeset:
<http://svn.openlaszlo.org/openlaszlo/patches/20080521-maxcarlson-e.tar
>> ><http://svn.openlaszlo.org/openlaszlo/patches/20080521-maxcarlso n-e.tar
>http://svn.openlaszlo.org/openlaszlo/patches/20080521-maxcarlson-e.tar
