Interesting. I didn't know you could do that.
Here's my concern: If a naive user (like myself) says:
<canvas width="100">
<debug width="200">
...
</canvas>
and you make your change, won't I end up with a debugger window where
I can't get to the resize tab so I can't make it fit on my window?
There's a boatload of heuristics going on here to make the debugger
window size as useful as possible, and I'd want to make sure we didn't
break any of those. In particular, look at the history of this bug
for an example of how dangerous what looks like a simple change can be:
http://jira.openlaszlo.org/jira/browse/LPP-7602
So, I'm pretty leery of your proposed change.
---
Why can't you just have the canvas be 100% and then set the actual
size using the embed tag?
On 2009-06-22, at 15:45EDT, Sarah Allen wrote:
If you have a larger width in the embed tag, you can test an app in
a larger canvas area than the canvas declares. It is likely not
intentional, but it is very useful. I often develop small LZX apps
embedded in a website, but for testing I embed them in larger area
of test files. It is good that the canvas stays the same size, so
the app isn't distorted when I'm debugging -- the larger debugger is
key.
Sarah
On Jun 22, 2009, at 12:39 PM, P T Withington wrote:
I'm not sure what you are asking. If you make the debugger wider
than the canvas, doesn't it just get clipped? How is that useful?
On 2009-06-21, at 17:57EDT, Sarah Allen wrote:
I'd like to change this line in debugger.lzx:
super.setAttribute('width', Math.max( 170 , Math.min( w ,
canvas.width) ) );
to
super.setAttribute('width', Math.max( 170 , w ) );
I've done this locally, since I am working with a somewhat narrow
video player and I just stick it into a test html with a larger
width than is defined on teh canvas, so it looks just like it does
on the real site, but I can develop with a larger debugger window.
If no one objects (and someone else approves) I'll file a bug and
check it in. (I can also do the same for the height although it
is not as important)
Thanks,
Sarah
http://www.ultrasaurus.com
