Approved
(based on my limited knowledge about the compiler, but Henry is also on
review list, so I wouldn't worry too much :-) )
Just one nit:
> // Only neuter Errors if either catcherrors or debug is on and
> throwsError is off
> if ((catchExceptions || debugExceptions) && (! throwExceptions)) {
If throwsExceptions is 'false', then either catchExceptions or
debugExceptions (or both) is 'true', so
this could be simplified to: "if (! throwsExceptions)"
While inspecting the output for DHTML, I've noticed two other bugs (or
better two inefficiencies):
- LPP-8513 (Improved debugging of runtime errors injects unnecessarily
"with(this)")
- LPP-8514 (Improved debugging of runtime errors should use "instanceof"
for DHTML)
On 9/25/2009 7:26 PM, P T Withington wrote:
> Change 20090925-ptw-s by [email protected] on 2009-09-25 11:41:42 EDT
> in /Users/ptw/OpenLaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Eliminate Debug.evalCarefully, now that it is no longer needed
>
> Bugs Fixed: LPP-8479 Debug.evalCarefully not necessary after LPP-8222?
>
> Technical Reviewer: [email protected] (pending)
> QA Reviewer: hminsky (pending)
>
> Release Notes:
> When debugging is on, we will catch, report, and ignore errors
> that are not specifically declared with `#pragma
> "throwsError=true".
>
> Details:
> JavascriptGenerator: Replace the concept of a 'checked node' with
> just making sure the source annotations are correct, in case the
> node causes a runtime error. In the error handler, if backtracing
> is on, use the more accurate runtime line information.
>
> Compiler.java: Add a subclass of PassthroughNode, AnnotatedNode,
> so we can be a little more efficient and not double-annotate.
> (This unfortunately doesn't prevent all redundant settings of the
> backtrace line number.)
>
> Tests:
> Verify that test case in bug displays error (with correct line
> number, when backtrace is enabled).
>
> Examine output of compiler in DHTML to see that line annotations
> are inserted for "checked" nodes.
>
> smokecheck x {swf10, dhtml}
>
> Files:
> M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
> M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20090925-ptw-s.tar
>
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
