On 2009-09-26, at 16:26, André Bargull wrote:
> Approved
> (based on my limited knowledge about the compiler, but Henry is also
> on review list, so I wouldn't worry too much :-) )
>
> Just one nit:
>> // Only neuter Errors if either catcherrors or debug is on and
>> throwsError is off
>> if ((catchExceptions || debugExceptions) && (!
>> throwExceptions)) {
> If throwsExceptions is 'false', then either catchExceptions or
> debugExceptions (or both) is 'true', so
> this could be simplified to: "if (! throwsExceptions)"
Actually, I think I can greatly simplify the logic of this whole
section. I'm going to revise and ask you to re-review, to make sure I
have the logic right.
> While inspecting the output for DHTML, I've noticed two other bugs
> (or better two inefficiencies):
> - LPP-8513 (Improved debugging of runtime errors injects
> unnecessarily "with(this)")
Thanks for spotting this. Surely due to the free variable analyzer
being too conservative.
> - LPP-8514 (Improved debugging of runtime errors should use
> "instanceof" for DHTML)
Another good catch. I'd like to fix this by fixing LPP-6692 if
possible.
> On 9/25/2009 7:26 PM, P T Withington wrote:
>> Change 20090925-ptw-s by [email protected] on 2009-09-25 11:41:42 EDT
>> in /Users/ptw/OpenLaszlo/trunk
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Eliminate Debug.evalCarefully, now that it is no longer
>> needed
>>
>> Bugs Fixed: LPP-8479 Debug.evalCarefully not necessary after
>> LPP-8222?
>>
>> Technical Reviewer: [email protected] (pending)
>> QA Reviewer: hminsky (pending)
>>
>> Release Notes:
>> When debugging is on, we will catch, report, and ignore errors
>> that are not specifically declared with `#pragma
>> "throwsError=true".
>>
>> Details:
>> JavascriptGenerator: Replace the concept of a 'checked node' with
>> just making sure the source annotations are correct, in case the
>> node causes a runtime error. In the error handler, if backtracing
>> is on, use the more accurate runtime line information.
>>
>> Compiler.java: Add a subclass of PassthroughNode, AnnotatedNode,
>> so we can be a little more efficient and not double-annotate.
>> (This unfortunately doesn't prevent all redundant settings of the
>> backtrace line number.)
>>
>> Tests:
>> Verify that test case in bug displays error (with correct line
>> number, when backtrace is enabled).
>>
>> Examine output of compiler in DHTML to see that line annotations
>> are inserted for "checked" nodes.
>>
>> smokecheck x {swf10, dhtml}
>>
>> Files:
>> M WEB-INF/lps/server/src/org/openlaszlo/sc/
>> JavascriptGenerator.java
>> M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090925-ptw-s.tar
>>
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
