In both swf8 and swf10 the custom cursor changes to a hand when I click and release the mouse button on the gray boxes in cursor1.lzx and cursor2.lzx. I guess this is from calling unlock() onmouseup?
lfc-undeclared.lzx lists width and height for the resource tag, but they appear to be unused. I'd expect offsets to be added instead of subtracted in LzMouseKernel. Also, it seems like x and y offsets should work for any resource - not just when a resource is used as a cursor. Please consider refactoring some of the logic that writes resource descriptors into ObjectWriter. It seems like there's potential for skew in DHTML and SWF9 now... One more thing: swf8 doesn't need a resource table - you should be able to offset the compiled resource directly using the jgenerator APIs. Henry Minsky wrote: > UPDATED > had to fix bug in code which decides which cursor is used in LzText > > Change 20091024-hqm-K by [email protected] on 2009-10-24 19:40:04 EDT > in /Users/hqm/openlaszlo/trunk6 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: make custom cursors work in swf10, add groundwork for DHTML > > New Features: > > Bugs Fixed: LPP-8563 > > Technical Reviewer: max > QA Reviewer: andre > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > > This change makes several custom cursor features work in swf10; the > use of bitmap resources, hotspot offsets, and global control of the > whether the handcursor is enabled over clickable views. > > It lays the groundwork for bitmap cursors in DHTML, and cursor hotspot > offsets in SWF8. > > + add 'offsetx' and 'offsety' attributes to <resource> tag, so > LzMouseKernel can > implement hotspots for bitmap cursors. These are passed through the the > LzResourceLibrary > object in SWF10, DHTML. SWF8 has not yet got a LzResourceLibrary object, > so it has > no place to store the offset info for resources. > > + If found on for a resource entry in LzResourceLibrary, LzMouseKernel > uses offsetx, offsety to offset the resource. > > > > Tests: > > test/cursor/cursors.lzx in swf10, swf8 > > Files: > D test/cursors.lzx > A test/cursor > A test/cursor/grid_cursor.swf > A test/cursor/sort_arrow_up.swf > A test/cursor/cursor_wait.png > A test/cursor/cursor1.lzx > A test/cursor/cursor2.lzx > A test/cursor/cursors.lzx > A test/cursor/cursor_crosshair.png > M WEB-INF/lps/schema/lfc-undeclared.lzx > M WEB-INF/lps/lfc/kernel/swf9/LzMouseKernel.as > M WEB-INF/lps/lfc/kernel/swf9/LzSprite.as > M WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ObjectWriter.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ResourceCompiler.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWFWriter.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java > > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091024-hqm-K.tar -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
