Can you elaborate on the theory of what the view's x/y/width/height coordinates mean when there are box-model elements? If I were familiar with the HTML model, I would expect the border and margin to be _outside_ of my x/y/width/height and padding to be _inside_. This will happen by default in dhtml, but in the swf9 kernel and the mixin, it seems like you are putting all 3 box components outside the view's coordinates. Am I mis-reading? If not, can you explain a little more so others will not be misled?
Otherwise, looks good. On 2009-12-04, at 18:00, Max Carlson wrote: > Change 20091204-maxcarlson-1 by maxcarl...@bank on 2009-12-04 14:50:43 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Add CSS box model to dhtml and swf9/10 via mixins > > Bugs Fixed: LPP-8552 - CSS like border styling on views > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Release Notes: With the boxmodel mixin, views support CSS2 box model padding, > margin, borderwidth and bordercolor properties in dhtml and swf9/10. See > http://www.w3.org/TR/CSS2/box.html for more details. > > Details: LzSprite.js - Add css2boxmodel capability, set to true. Add > implementation of setCSS() that knows how to style the appropriate divs. > setCSS() can be used to apply CSS in a very lightweight fashion in the future. > > LzSprite.as - Add css2boxmodel capability, set to true. Rename draw() -> > drawBackground(), update to understand margins, borders and padding. Cache > true x and y position to be used in computing sprite offsets based on > padding/margins. Add implementation of setCSS() that manages the margin, > padding, borderwidth and bordercolor properties. > > LaszloView - Add view.usegetbounds property, used to check if getBounds() > must be used to get accurate measurements. Update getBounds() to account for > width and height offsets. Add setCSS() to call into the sprite when a given > CSS property is supported. > > lzs-autoincludes - Add boxmodel.lzx to the auto includes. > > layouts/* - Update to use getBounds() for size measurement when usegetbounds > is true. > > mixins/boxmodel.lzs - Implement basic CSS2 box model support with margin, > padding, borderwidth and bordercolor attributes. > > Tests: See LPP-8552 for a simple testcase that works in dhtml and swf9/10. > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/kernel/swf9/LzSprite.as > M WEB-INF/lps/lfc/views/LaszloView.lzs > M WEB-INF/lps/misc/lzx-autoincludes.properties > M lps/components/utils/layouts/wrappinglayout.lzx > M lps/components/utils/layouts/stableborderlayout.lzx > M lps/components/utils/layouts/simplelayout.lzx > M lps/components/utils/layouts/reverselayout.lzx > A lps/components/mixins > A lps/components/mixins/boxmodel.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20091204-maxcarlson-1.tar _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
