Approved, with one amendment: Can you mark __itemclass as being private?
On 2010-01-06, at 15:06, Max Carlson wrote: > Change 20100105-maxcarlson-T by maxcarl...@bank on 2010-01-05 14:09:06 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED ONCE AGAIN: Fix lz/list.lzx to use correct methods for > instantiating new items > > Bugs Fixed: LPP-6002 - lztextlistitem warning/errors of undefined properties > (title, height, setAttribute), LPP-8690 - Update components to use class > references directly instead of tagnames (partial) > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: Per Tucker's suggestion, cache the __itemclass separately, and only > use in cases where itemclassname isn't set. addItem() creates instances > using __itemclass, and sets __itemclass in the itemclassname setter. > Subclasses of baselist _must_ explicitly set __itemclass when itemclassname > is not used. > > > Tests: Testcase from LPP-6002 no longer warns, component_sampler.lzx > continues to work. lzunit-basedatacombobox.lzx runs as before. > > Files: > M lps/components/lz/list.lzx > M lps/components/base/basetabslider.lzx > M lps/components/base/baselist.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100105-maxcarlson-T.tar > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
