On Sat, Feb 13, 2010 at 2:19 PM, P T Withington <[email protected]>wrote:
> Comments: > > In ClassCompiler, can you just remove the code that was not the solution. > I think it could be confusing to leave it there commented out. > > In NodeModel and ClassModel, where you had to add the env parameter, can > you add a comment explaining that why? Essentially, that the "emitters" may > be emitting to different `env`s for loadable libraries. > > Did you verify that the .lzo test cases still work? I think they are at > risk because dynamic and binary library processing seem to intersect a lot. > I will do some tests for that. So you have any tests that you typically use? I started a very simpleminded lztest suite but need to add a bunch more variants of that to get more corner cases . > > Otherwise approved. > > On 2010-02-12, at 21:26, Henry Minsky wrote: > > > added missing file > > > > > > Change 20100212-hqm-k by [email protected] on 2010-02-12 17:08:20 EST > > in /Users/hqm/openlaszlo/trunk-clean > > for http://svn.openlaszlo.org/openlaszlo/trunk > > > > Summary: fix for swf9 dynamic libraries > > > > New Features: > > > > Bugs Fixed: LPP-8727 bug in dynamically loaded library in swf9/10 > > > > Technical Reviewer: ptw > > QA Reviewer: max > > Doc Reviewer: (pending) > > > > Documentation: > > > > Release Notes: > > > > Overview: > > > > Removed CompilationEnvironment instance var from ClassModel. > > > > Pass compilation environment in from ImportCompiler to ClassModel, so > that classes are > > emitted into the correct output stream > > > > > > Details: > > > > I missed a case in the last patch, for NodeModel.asMap which calls > emitClassDeclaration > > > > NodeModel.java: > > + Pass CompilationEnvironment arg to ClassModel.emitClassDeclaration > > > > ClassModel.java: > > + Add CompilationEnvironment arg to getNodeModel > > > > + Pass CompilationEnvironment arg to getNodeModel > > > > Other files had to be changed to add extra env arg to NodeModel.asMap() > > > > > > Tests: > > > > + test case from bug report, in swf10, swf8, dhtml > > + smokecheck > > + test/snippets/import-view > > + test/snippets/import-class-and-view-direct > > > > > > Files: > > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java > > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewCompiler.java > > M > WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java > > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java > > M > WEB-INF/lps/server/src/org/openlaszlo/compiler/ImportCompiler.java > > M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java > > M WEB-INF/lps/server/src/org/openlaszlo/compiler/DebugCompiler.java > > M > WEB-INF/lps/server/src/org/openlaszlo/compiler/SplashCompiler.java > > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java > > > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100212-hqm-k.tar > > > > _______________________________________________ > > Laszlo-reviews mailing list > > [email protected] > > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews > > -- Henry Minsky Software Architect [email protected]
_______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
