On 2010-02-13, at 16:24, Henry Minsky wrote: > On Sat, Feb 13, 2010 at 2:19 PM, P T Withington <[email protected]>wrote: > >> Comments: >> >> In ClassCompiler, can you just remove the code that was not the solution. >> I think it could be confusing to leave it there commented out. >> >> In NodeModel and ClassModel, where you had to add the env parameter, can >> you add a comment explaining that why? Essentially, that the "emitters" may >> be emitting to different `env`s for loadable libraries. >> >> Did you verify that the .lzo test cases still work? I think they are at >> risk because dynamic and binary library processing seem to intersect a lot. >> > > I will do some tests for that. So you have any tests that you typically > use? > I started a very simpleminded lztest suite but need to add a bunch more > variants > of that to get more corner cases .
I think you have written the only tests (other than "does webtop work?"). http://jira.openlaszlo.org/jira/browse/LPP-8617 It has links to various bugs that suggest possible test cases. _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
