Metasuite passes with two compiler errors:
constraints/constraint-test.lzx:65:67: The attribute 'width' has a
non-constant $style binding, which is not supported
resource/resource-not-found.lzx:35:44: Can't import /resource/main.lzx:
Can't import /resource/main.lzx: bad mime type
test/style/constraints/main.lzx has this error:
constraints/constraint-test.lzx:65:67: The attribute 'width' has a
non-constant $style binding, which is not supported
And fails this test:
ERROR: perry should have an x of 0: expected 0 got (void 0)
I'm not sure why metasuite doesn't completely include the entire set of
constraint tests, so that should be fixed and the warnings/errors
cleaned up. Otherwise, approved!
Regards,
Max Carlson
OpenLaszlo.org
On 4/21/10 8:13 AM, P T Withington wrote:
Change 20100421-ptw-K by [email protected] on 2010-04-21 11:05:04 EDT
in /Users/ptw/OpenLaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: No more dynamically computed CSS style property names
Bugs Fixed: LPP-8925 Remove support for dynamically computed CSS style property
names
Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)
Overview:
No one ever uses `value=$style{<random string-valued
expression>}`, it is uneccesary generality and prevents us from
optimizing style constraints. The new syntax `style="propname"`
is much more streamlined and allows you to specify a fallback
value when there is no applicable CSS binding.
Details:
Remove the test case, replace it with a new style example. Signal
an error if the value of a $style constraint is not a constant
string.
Tests:
smokecheck, test/style/metasuite.lzx
Files:
M test/style/constraints/constraint-test.lzx
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100421-ptw-K.tar
