LzFormatCallback invokes the callback function without any arguments:
+ function call () {
+ return this.callback.call(null);
+ }
but here you're adding a 'ignore-argument':
+ function (ignore=null) {
+ navigateToURL(new
URLRequest("http://www.adobe.com/support/flashplayer/downloads.html";),
"_blank");
+ },
You may want to make this consistent.
Do you want to document the %^ directive for public use? Or do you want
this to be private for the time being?
Otherwise approved.
On 4/24/2010 5:44 PM, P T Withington wrote:
Change 20100424-ptw-n by [email protected] on 2010-04-24 11:14:05 EDT
in /Users/ptw/OpenLaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Debugger tweaks
Bugs Fixed:
LPP-8930 Debugger needs a public (supported) API to get the in-app console
window (if it exists)
LPP-8925 Remove support for dynamically computed CSS style property names
LPP-8926 DHTML: not possible to inspect debug warnings properly
Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)
Details:
LzModeManager: Use internal Debug API to avoid debugger console
window when it is on the canvas.
LzDebug.lzx, LzBootstrapDebugService: Create an internal API for
above. Create a public API for ensuring the debugger console is
visible. Add support for general callbacks from format strings
(%^ directive).
LzDebuggerWindowConsoleBridge.*: API for getting canvas console.
LzDebug.js: Use objectLinkHandler for object links so you can
prevent bubbling (LPP-8926).
LzDebug.as: Rework debug player warning to be less obtrusive, use
%^ to provide a link to the download page, and make sure that it
is output even if the user creates their own<debug />.
LzFormatter: Added %^ directive that lets you output a
'clickable' representation with an arbitrary function to be called
back when clicked.
DebugCompiler: Warn if multiple<debug /> tags (since all but the
first will be ignored).
lzunit: Ensure the test display is frontmost, and if debugging,
that the debug window is visible (in front of that), using the new
public API's
Tests:
smokecheck, metasuite, test case from bugs
Files:
M WEB-INF/lps/lfc/services/LzModeManager.lzs
M WEB-INF/lps/lfc/debugger/LzDebug.lzs
M WEB-INF/lps/lfc/debugger/platform/swf/LzDebuggerWindowConsoleBridge.as
M WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
M WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebuggerWindowConsoleBridge.js
M WEB-INF/lps/lfc/debugger/platform/swf9/LzDebuggerWindowConsoleBridge.as
M WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
M WEB-INF/lps/lfc/compiler/LzFormatter.lzs
M WEB-INF/lps/lfc/compiler/LzBootstrapDebugService.lzs
M WEB-INF/lps/server/src/org/openlaszlo/compiler/DebugCompiler.java
M lps/components/lzunit/lzunit.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100424-ptw-n.tar
