On 2010-04-24, at 12:30, André Bargull wrote:

> LzFormatCallback invokes the callback function without any arguments:
>> + function call () {
>> +   return this.callback.call(null);
>> + }
> 
> but here you're adding a 'ignore-argument':
>> + function (ignore=null) {
>> +   navigateToURL(new 
>> URLRequest("http://www.adobe.com/support/flashplayer/downloads.html";), 
>> "_blank");
>> + },
> 
> You may want to make this consistent.

Done.

> Do you want to document the %^ directive for public use? Or do you want this 
> to be private for the time being?

Not yet.  I'd like to get some experience using it before making it a feature.  
Things to think about:

1) Is %^ the right name for this feature?

2) Should the callback get the event that triggered it as an argument (say, to 
be able to dispatch on the actual mouse gesture).

3) This feature duplicates some of the 'text link' feature in the LFC, should 
there be some unification, or is it good for the debugger to have it's own 
separate mechanism.



Reply via email to