Fair 'buff. Approved for QA!
Regards,
Max Carlson
OpenLaszlo.org
On 5/27/10 12:51 PM, P T Withington wrote:
On 2010-05-27, at 15:38, Max Carlson wrote:
I get this:
OpenLaszlo 5.0.x: copy-of-hello (trunk-clean/my-apps/copy-of-hello)
That's what I intend.
Since trunk-clean is almost always equivalent to the version number, why not
remove it?
At least for me, I often have many copies of trunk going at once (one to review
in, one that is truly clean to test in, one or more that I am actively
developing in). Without the 'servlet context', I can't distinguish between
which one I am running. Say I want to compare my dev version against clean.
Also, why list copy-of-hello twice,
I list it twice because different browsers abbreviate long titled differently.
Safari truncates on the right, Firefox elides the middle. That way, at least
one position is hopefully going to show up. And again, if you happen to have
two apps with the same file name, I append the actual path to the app to
disambiguate.
and why no .lzx extension?
Well _that_ I figured was redundant. All apps are going to be named .lzx, so
why waste space on that?
Regards,
Max Carlson
OpenLaszlo.org
On 5/27/10 8:55 AM, P T Withington wrote:
Change 20100527-ptw-X by [email protected] on 2010-05-27 11:48:47 EDT
in /Users/ptw/OpenLaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Give a more meaningful default title for OpenLaszlo applications
Bugs Fixed: LPP-9044 Make default title more descriptive - perhaps include the
path/filename
Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)
Details:
Include OpenLaszlo and version in default title (for advertising),
followed by the base name of the application file (which hopefully
will not be abbreviated), followed by the approximate context path
to the application (for disambiguation, but which may be truncated
in some browser history displays)
By having the application file name near the front and end of the
title, hopefully it will be visible in one place or the other,
depending on whether the browser truncates long titles at the end
or by leaving out the middle (Firefox seems to do both, depending
on where you look!)
Tests:
smokecheck, inspect browser title, history
Files:
M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/Canvas.java
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100527-ptw-X.tar
