Not approved:
- custom titles also include the filename and path, but I don't think they should so

<canvas title="My OL App" >
</canvas>

The title should be only "My OL App", but instead it's set to "My OL App: LPP-9044 (trunk/my-apps/testfolder/LPP-9044)".

On 5/27/2010 5:55 PM, P T Withington wrote:
Change 20100527-ptw-X by [email protected] on 2010-05-27 11:48:47 EDT
     in /Users/ptw/OpenLaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Give a more meaningful default title for OpenLaszlo applications

Bugs Fixed: LPP-9044 Make default title more descriptive - perhaps include the 
path/filename

Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)

Details:

     Include OpenLaszlo and version in default title (for advertising),
     followed by the base name of the application file (which hopefully
     will not be abbreviated), followed by the approximate context path
     to the application (for disambiguation, but which may be truncated
     in some browser history displays)

     By having the application file name near the front and end of the
     title, hopefully it will be visible in one place or the other,
     depending on whether the browser truncates long titles at the end
     or by leaving out the middle (Firefox seems to do both, depending
     on where you look!)

Tests:
     smokecheck, inspect browser title, history

Files:
M       WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
M       WEB-INF/lps/server/src/org/openlaszlo/compiler/Canvas.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100527-ptw-X.tar

Reply via email to