I like the idea of making the inspector a part of the debugger. (For
some reason the name 'Firebug' comes to my mind ;-) ). It could be a
real help for users and developers.
But I wouldn't add the current inspector as is to the debugger. We
should first gather some ideas which we'd like to have for a
debugger-integrated inspector. An integrated inspector could also use
private methods like __typeof without worrying whether to make the
methods publicly available.
That said, I'd like to commit this change without further updates. Some
reasons for this:
1) no need to think about how to use advanced methods of the debugger,
as for example __typeof, which may need to be made public
2) the current inspector even works with debug disabled, this wouldn't
be possible if __typeof was used
So this is more like a quick fix until we've got something better...
On 6/1/2010 5:46 PM, P T Withington wrote:
Would it be better to make the Debugger.__typeof interface public (maybe with a
better name) and use that instead? That would make this code more future-proof.
Even better, should we make the inspector a standard part of the debugger?
Make it a pane that you can open in the debug window? Integrate it with
Debug.inspect?
On 2010-05-31, at 13:36, André Bargull wrote:
Change 20100531-bargull-EWW by barg...@bargull02 on 2010-05-31 19:19:57
in /home/anba/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: some updates for the inspector to handle anonymous classes better
Bugs Fixed: LPP-9060 (inspector: no proper tagname for anonymous classes and
debug window not hidden)
Technical Reviewer: ptw
QA Reviewer: (pending)
Details:
The inspector needs to display the proper tagname, "<anonymous>" won't help
anyone here. There are now two additional methods:
- getTagName(): returns constructor.tagname if defined, otherwise checks for
anonymous classes by inspecting the classname and in case of anon classes
returns the superclass' tagname
- getDisplayName(): returns getTagName() if not null, otherwise returns the
classname
Two retrieve the superclass and the classname, separate definitions are needed
for swf8/dhtml and swf9+
Also updated switch clause to use the new tagname of the debugger.
Tests:
inspector-example works
Files:
M lps/components/utils/diagnostic/inspector/inspector.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100531-bargull-EWW.tar
