On 7/14/10 4:59 PM, André Bargull wrote:
+ if (options.serverroot == '') options.serverroot = '.';
This is already done in lfc():
lfc: function (url, serverroot) {
// Default serverroot to "." if an empty string is supplied
if (serverroot == '') {
serverroot = '.';
Right. I removed the redundant line.
Therefore I'd change this:
- if (properties.lfcurl && properties.serverroot) {
- lz.embed.lfc(properties.lfcurl, properties.serverroot);
+ if (properties.lfcurl && options.serverroot) {
+ lz.embed.lfc(properties.lfcurl, options.serverroot);
}
to:
if (properties.lfcurl && options.serverroot != null) {
lz.embed.lfc(properties.lfcurl, options.serverroot);
}
I removed the options.serverroot test and set
lz.embed.options.serverroot to '.' by default.
But shouldn't we inform the user when lfcurl or serverroot aren't set,
because in that case the lfc won't ever be loaded? Because that is what
actually happened to the user.
I added a warning, because if you haven't loaded the LFC by the
lz.embed.dhtml() call, something's wrong.
On 7/15/2010 1:26 AM, Max Carlson wrote:
Change 20100714-maxcarlson-7 by maxcarl...@friendly on 2010-07-14
16:22:18 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix embedding for DHTML SOLO apps
Bugs Fixed: LPP-9189 - DHTML: SOLO deploy doesn't work properly for 4.8
Technical Reviewer: [email protected]
QA Reviewer: hminsky
Details: dhtml() checks for falsy serverroot values, esp. '', early
return from __getqueryurl() includes an initarg property.
Tests: DHTML SOLO apps work again
Files:
M lps/includes/source/embednew.js
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100714-maxcarlson-7.tar
