No, I'm just saying Flash uses this mechanism, so it will be consistent across runtimes either way... No idea how Flash handles this, but I remember when we used the internal AS3 handler it gave a consistent value back because the Flash player was listening for the event.

On 9/22/10 1:15 PM, P T Withington wrote:
I understand what you are trying to do.

I'm not sure I see how it can work though, since the user could have set a 
custom acceleration curve for this?

When you say "This is the same mechanism used by Flash." are you saying Flash 
documents a scale factor for each browser and we are trying to be compatible with that?  
If that's the case, then I am more convinced of this being a reasonable change.

On 2010-09-22, at 15:14, Max Carlson wrote:

I was just trying to get it to be consistent across browsers.  This is the same 
mechanism used by Flash.  If you don't like the change let's leave it as-is!

On 9/22/10 4:33 AM, P T Withington wrote:
I guess this is a personal preference.  Safari seems slow to me now.

Do we really want to be doing this?  Won't this make OL apps look "sluggish" 
compared with other apps?  If Safari and Firefox have different mouse behavior, I would 
think we would want OL apps to follow the browser, not try to subvert it.

You ought to update your tools so you get the new improved patch names.

On 2010-09-14, at 16:46, Max Carlson wrote:

Change 20100914-maxcarlson-M by maxcarl...@friendly on 2010-09-14 13:43:16 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix mousewheel speeds to be more consistent.

Bugs Fixed: LPP-9369 - Safari OSX: mousewheel way to fast

Technical Reviewer: hminsky
QA Reviewer: ptw

Details: mousewheel - Compensate for Safari 5's huge mousewheel delta values, 
make Firefox a little quicker.

embednew - Add explicit scoping for handler registration/unregistration.

Tests: test/lfc/legals/keyboardandmouse.lzx?lzr=dhtml&lzt=html shows normal 
mousewheel speed in Safari and Firefox.

Files:
M       lps/includes/source/mousewheel.js
M       lps/includes/source/embednew.js

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20100914-maxcarlson-M.tar




Reply via email to