I propose we change 'started' (meaning the animation is running) to 'running' because it's more clear. Otherwise, this looks great to me!

On 3/8/10 12:14 PM, P T Withington wrote:
<animatorgroup>  (and hence<animator>) have some complexities in their API that 
I would like to clean up in 5.0:

Attributes:

+ `start`:  is effectively write-only and collides with the event `onstart` 
which it only indirectly effects.

The value of `start` is currently stored in the attribute `started`, but if you 
change the value of `started` it will _not_ have the same effect as changing 
`start`.

I propose we deprecate `start` and replace it with `started` (or perhaps, since 
we are changing it, use a more descriptive term like `autostart`); in a 
subsequent release we can remove `start` altogether as an attribute.

+ `isactive`:  should have been a private attribute

I propose that it be deprecated and made private in a subsequent release.


Methods:

`doStart` =>  `setAttribute('started', true)`
`stop` =>  `setAttribute('started', false)`

If we choose a different name for `started`, obviously that would be applied 
here.

I propose that these methods be deprecated and made private in a subsequent 
release.


Events:

It seems it would also be nice if we could have the tense of the events agree.  
We currently have `onstart`, `onpaused`, `onstop`.  If we don't use `started` 
as an attribute, we could make these be `onstarted`, `onpaused`, and 
`onstopped`.  But perhaps that is going too far?


Your comments solicited.

_______________________________________________
Diamond mailing list
[email protected]
https://hedwig.laszlosystems.com/mailman/listinfo/diamond

Reply via email to