I'm heartily in favour of not having nitpicky reasons to reject or recycle contributions. (cf the typo test.)
I don't know if a Python pretty printer equivalent to gofmt exists and is highly trustworthy, so the discussion may be moot. I like what we do in bzr wrt formatting: * only comment on formatting during review if it's actually gross or hard to read or sticks out (eg a 200-character line) * keep in mind the point is to get things landed * pep8 defines what we converge upon, so we don't have flip-flop changes on personal opinion * people who care a lot (and maybe have editor integration) are welcome to clean things up as they touch files It seems to me there is O(n*m) behaviour in Launchpad by having lint warnings mentioned in every review but never actually fixed. It is good to get tests to be just red/green rather than requiring human interpretation every time. In other words just either fix them or turn them off. I just landed a change in bzr to stop it moaning about format errors from selftest, since the warnings were just being ignored. So in short: * functional warnings are errors * formatting issues are only enforced by human reviewers _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : launchpad-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
