Stylistically,
 * Please fill in __all__ for lib/lp/registry/browser/webservice.py.
 * Change the docstring """Render a recipe owner as a link.""" to not use 
"recipe"

More broadly, why did you need to do this? Why do you *not* need to do this for 
all of the many other links to person for Launchpad? Does this override 
whatever stuff is in tales.py? The comment refers to a bug in lp.app, but 
there's no reference to the bug?
-- 
https://code.launchpad.net/~thumper/launchpad/webservice-person-adapter/+merge/46658
Your team Launchpad code reviewers is requested to review the proposed merge of 
lp:~thumper/launchpad/webservice-person-adapter into lp:launchpad.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to