Review: Approve code
Diff comments:
>
> === modified file 'lib/lp/codehosting/scanner/events.py'
> --- lib/lp/codehosting/scanner/events.py 2015-07-08 16:05:11 +0000
> +++ lib/lp/codehosting/scanner/events.py 2015-09-24 13:55:55 +0000
> @@ -82,6 +82,14 @@
> """The new tip revision id from this scan."""
> return self.bzr_branch.last_revision()
>
> + @staticmethod
> + def composeWebhookPayload(branch, old_revid, new_revid):
> + return {
> + "bzr_branch_path": branch.unique_name,
git:push:0.1 uses the shortest alias. We should be consistent, either way.
> + "old": {"revision_id": old_revid},
> + "new": {"revision_id": new_revid},
> + }
> +
>
> class IRevisionsRemoved(IObjectEvent):
> """Revisions have been removed from the branch."""
--
https://code.launchpad.net/~cjwatson/launchpad/bzr-webhooks/+merge/272248
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
