Christian Ulrich schreef:
Can somebody please tell me whats wron with this patch ?
Did you really expect an answer within 20 hours?
Can somebody please tell me, what is wrong with the note 9741 on bug
http://www.freepascal.org/mantis/view.php?id=2066 . I waiting now for
more than 4 days for feedback from the reporter.
I found a little time to look at this patch.
First:
I doubt the general usefulness of having the applicationtype as member
of TApplicationProperties. TApplicationProperties are part of a from,
which is created at its earliest *after* the call to
Application.Initialize. So generally the ApplicationType isn't changed
until known after the call to TWidgetSet.Create *and*
TWidgetSet.AppInit. This limits its usefulness.
I think it would be better to set the ApplicationType in the Project
Options as part of the Application Settings groupbox. The IDE would
add/edit/remove the
Application.ApplicationType := atDesktop;
line just before Application.Initialize in the .lpr file.
Secondly the patch contains several fixes at once. It is better to
create separate patch files for it.
Or apply it !?
I cannot do it, I don't apply LCL and wince patches without consent of
other lazarus developers, unless the patch is trivial and undisputed.
Vincent
Christian
Christian Ulrich schrieb:
On 11/12/06, Christian Ulrich <[EMAIL PROTECTED]> wrote:
And also in TApplicationproperties so it can be set in an visual way
...
Can you implement this? It would be nice to have all modifications
related to this on a single patch.
If no one objects I will suppose TApplicationproperties is a
acceptable way. Just make sure you can set this both visually and by
code.
Here it is, TApplication and TApplicationProperties have an
ApplicationType
property
and the wince apps close correctly and looks like they schould on pdas
and
smartphones ;)
Hope this will be applied ...
Christian
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
