results of static code analysis using VisualStudio 2008 TeamSuite some are bogus, but some are simple to fix ... eg cmsio1.c(934) and cmsio1.c(1043)
cmscgats.c(422) : warning C6328: 'const char' passed as parameter '1' when 'unsigned char' is required in call to 'isalpha' cmscgats.c(440) : warning C6053: Call to 'strncpy' might not zero-terminate string 'buffer': Lines: 435, 437, 439, 440 cmscgats.c(1964) : warning C6053: Call to 'strncpy' might not zero-terminate string 'Buffer': Lines: 1928, 1929, 1930, 1931, 1933, 1935, 1937, 1938, 1940, 1942, 1948, 1949, 1940, 1942, 1948, 1949, 1952, 1954, 1956, 1958, 1959, 1960, 1962, 1964 cmscgats.c(2444) : warning C6054: String 'Type' might not be zero-terminated: Lines: 2423, 2424, 2425, 2427, 2430, 2431, 2433, 2434, 2436, 2439, 2442, 2444 cmserr.c(95) : warning C6053: Call to '_vsnprintf' might not zero-terminate string 'Buffer2': Lines: 61, 63, 65, 67, 90, 91, 93, 94, 95 cmserr.c(95) : warning C6053: Call to '_snprintf' might not zero-terminate string 'Buffer1': Lines: 61, 63, 65, 67, 90, 91, 93, 94, 95 cmsgamma.c(475) : warning C6262: Function uses '49196' bytes of stack: exceeds /analyze:stacksize'16384'. Consider moving some data to heap cmsgamma.c(510) : warning C6262: Function uses '49196' bytes of stack: exceeds /analyze:stacksize'16384'. Consider moving some data to heap cmsgamma.c(713) : warning C6262: Function uses '49188' bytes of stack: exceeds /analyze:stacksize'16384'. Consider moving some data to heap cmsgamma.c(897) : warning C6262: Function uses '49188' bytes of stack: exceeds /analyze:stacksize'16384'. Consider moving some data to heap cmsgmt.c(667) : warning C6386: Buffer overrun: accessing '(LabTable[0])->GammaTable', the writable size is '2' bytes, but '4' bytes might be written: Lines: 656, 658, 659, 660, 666, 667 cmsintrp.c(549) : warning C6246: Local declaration of 'a' hides declaration of the same name in outer scope. For additional information, see previous declaration at line '525' of 'lcms-1.17\src\cmsintrp.c': Lines: 525 cmsintrp.c(549) : warning C6246: Local declaration of 'b' hides declaration of the same name in outer scope. For additional information, see previous declaration at line '525' of 'lcms-1.17\src\cmsintrp.c': Lines: 525 cmsintrp.c(1032) : warning C6385: Invalid data: accessing 'p8->rx', the readable size is '512' bytes, but '516' bytes might be read: Lines: 1010, 1011, 1012, 1013, 1014, 1015, 1016, 1020, 1021, 1022, 1024, 1025, 1026, 1028, 1029, 1030, 1032 cmsintrp.c(1033) : warning C6385: Invalid data: accessing 'p8->ry', the readable size is '512' bytes, but '516' bytes might be read: Lines: 1010, 1011, 1012, 1013, 1014, 1015, 1016, 1020, 1021, 1022, 1024, 1025, 1026, 1028, 1029, 1030, 1032, 1033 cmsintrp.c(1034) : warning C6385: Invalid data: accessing 'p8->rz', the readable size is '512' bytes, but '516' bytes might be read: Lines: 1010, 1011, 1012, 1013, 1014, 1015, 1016, 1020, 1021, 1022, 1024, 1025, 1026, 1028, 1029, 1030, 1032, 1033, 1034 cmsio1.c(667) : warning C6246: Local declaration of 'j' hides declaration of the same name in outer scope. For additional information, see previous declaration at line '482' of 'lcms-1.17\src\cmsio1.c': Lines: 482 cmsio1.c(934) : warning C6385: Invalid data: accessing 'ParamsByType', the readable size is '20' bytes, but '24' bytes might be read: Lines: 864, 865, 866, 867, 870, 871, 914, 916, 917, 918, 919, 920, 921, 923, 924, 926, 927, 933, 934 cmsio1.c(1043) : warning C6385: Invalid data: accessing 'ParamsByType', the readable size is '20' bytes, but '24' bytes might be read: Lines: 962, 963, 964, 965, 968, 970, 1022, 1024, 1025, 1026, 1027, 1028, 1029, 1032, 1033, 1035, 1036, 1042, 1043 cmsio1.c(3582) : warning C6031: Return value ignored: '_unlink' cmsmatsh.c(99) : warning C6011: Dereferencing NULL pointer 'NewMatShaper': Lines: 92, 93, 95, 96, 99 cmsmatsh.c(151) : warning C6011: Dereferencing NULL pointer 'NewMatShaper': Lines: 144, 145, 147, 148, 151 cmsxform.c(591) : warning C6386: Buffer overrun: accessing '(gxyz[0])->GammaTable', the writable size is '2' bytes, but '4' bytes might be written: Lines: 564, 565, 566, 567, 568, 571, 574, 575, 576, 580, 582, 583, 585, 586, 588, 591 cmsxform.c(592) : warning C6386: Buffer overrun: accessing '(gxyz[1])->GammaTable', the writable size is '2' bytes, but '4' bytes might be written: Lines: 564, 565, 566, 567, 568, 571, 574, 575, 576, 580, 582, 583, 585, 586, 588, 591, 592 cmsxform.c(593) : warning C6386: Buffer overrun: accessing '(gxyz[2])->GammaTable', the writable size is '2' bytes, but '4' bytes might be written: Lines: 564, 565, 566, 567, 568, 571, 574, 575, 576, 580, 582, 583, 585, 586, 588, 591, 592, 593 Louis Solomon www.SteelBytes.com ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Lcms-user mailing list Lcms-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lcms-user
