Quoting Richard Hughes <hughsi...@gmail.com>:
>
> It seems someone else has hit this in production too[1] -- so it's not
> just my system. Could you consider the attached patch please?


I was going to add this to make rc3, but now I realize you want something like

cmsBool CMSEXPORT cmsDictAddEntry(cmsHANDLE hDict, const wchar_t* Name,
{

  - _cmsAssert(Name != NULL);
  + if (Name == NULL) {
  +     error blah blah
  +     return false;
  +  }


So my question is why not to check "Name" before calling  
cmsDictAddEntry. If I add a check for a parameter in this function,  
for consistency sake I should add similar checks on nearly all lcms  
functions taking pointers. Please don't get me wrong, I would be glad  
to add this if it is really necessary, but I feel it is like a  
temporary hack, and would change the normal operation mode.


Ideas?

Regards
Marti



------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Lcms-user mailing list
Lcms-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lcms-user

Reply via email to